-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agnocastlib): implement Agnocast-ROS2 functionality #326
Conversation
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Co-authored-by: atsushi yano <55824710+atsushi421@users.noreply.github.com>
I think this is better. |
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@veqcc |
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
こちらの件、subscription もインターフェースを統一しました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
|
まで完了したので、再度 approve お願いします! universe の方も同時マージできると助かります |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
struct PublisherOptions : rclcpp::PublisherOptionsBase
{
bool do_always_ros2_publish;
}; このような構造体を想定していますか? |
@bdm-k |
@bdm-k @veqcc
だけで作ってもらって機能性が保持されることを確認した上でPRをmergeしましょう。 |
Description
Implemented Agnocast -> ROS 2 bridge functionality.
Major changes are:
bridge
directorynode_interface
fornode
in bothcreate_publisher
andcreate_subscription
publish()
function to check whether to publish ROS 2 messages every timeget_subscription_count()
function to fix get_subscription_count が Agnocast の subscription しかカウントできない #181Related links
Design Document (TIER IV internal)
How was this PR tested?
Confirmed that
transient_local
are subscribed by both Agnocast and ROS 2, andtransient_local_with_flag
are subscribed only by Agnocast.Notes for reviewers
do_always_ros2_publish
will be unified toAgnocast::PublisherOptions
later in create_publisher が options 引数を取れるようにする #306node_interfaces
tonode
even in subscriptions?