Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracepoints for CARET #327

Merged
merged 5 commits into from
Jan 24, 2025
Merged

feat: add tracepoints for CARET #327

merged 5 commits into from
Jan 24, 2025

Conversation

atsushi421
Copy link
Contributor

@atsushi421 atsushi421 commented Jan 20, 2025

Description

CARETで計測可能にするためのトレースポイント追加。

Related links

How was this PR tested?

  • sample application (required)
  • Autoware (required)

Notes for reviewers

まだ不足しているトレースポイントがあったり、各トレースポイントの内容も改善の余地があるかもしれませんが、一旦主要メトリクスが計測できるようになったので、PRを出しました。CARETにマージするタイミングでこの改善はやります。

@atsushi421 atsushi421 force-pushed the add_tracepoints_for_caret branch from 1aadb38 to 1e57b61 Compare January 23, 2025 08:24
@atsushi421 atsushi421 requested review from veqcc and Koichi98 January 24, 2025 02:38
@atsushi421 atsushi421 marked this pull request as ready for review January 24, 2025 02:38
@veqcc
Copy link
Contributor

veqcc commented Jan 24, 2025

Agnocastを用いた通信をプロセス内で行うことは無いと仮定している。

と「実装の概要」資料にありますが、#328 においてプロセス内でも Agnocast 通信をできるように変更されています。このあたりはどうなりますか?

@atsushi421
Copy link
Contributor Author

atsushi421 commented Jan 24, 2025

Agnocastを用いた通信をプロセス内で行うことは無いと仮定している。

と「実装の概要」資料にありますが、#328 においてプロセス内でも Agnocast 通信をできるように変更されています。このあたりはどうなりますか?

Agnocastでプロセス内通信が行われている場合でも、それがプロセス外通信としてCARETのインタフェースで表示されてしまうのみで、現状の実装でresponse time, comm latency等は出せます!
なので、低優先度のTODOとして積んでおくぐらいで良いかもしれません。

@atsushi421 atsushi421 added the run-build-test Run build-test in CI label Jan 24, 2025
Copy link

------------------------------------------------------------------------------
                           GCC Code Coverage Report
Directory: .
------------------------------------------------------------------------------
File                                       Lines    Exec  Cover   Missing
------------------------------------------------------------------------------
src/agnocastlib/include/agnocast.hpp           2       2   100%   
src/agnocastlib/include/agnocast_executor.hpp
                                               1       0     0%   38
src/agnocastlib/include/agnocast_publisher.hpp
                                              35      27    77%   71,94-95,110-112,116-117
src/agnocastlib/include/agnocast_smart_pointer.hpp
                                              53      50    94%   77,80-81
src/agnocastlib/include/agnocast_topic_info.hpp
                                              13      13   100%   
src/agnocastlib/src/agnocast.cpp              82      15    18%   22,24,27,30,32-34,36,39,42,44-50,54-55,58-62,66-67,71-74,77,80,82-85,88,91,93-94,96-97,102,104-106,109-112,115,117-123,125,138-139,150-151,154-156,161
src/agnocastlib/src/agnocast_component_container.cpp
                                              12       0     0%   5,7-8,11-13,16,18-20,22-23
src/agnocastlib/src/agnocast_component_container_mt.cpp
                                              28       0     0%   7,11-12,14-16,18-20,22-24,26-28,30,32-33,35-37,40,42,44-46,48-49
src/agnocastlib/src/agnocast_executor.cpp
                                              86       0     0%   11,13,15-17,19-21,25,27,30,32-33,36-40,43-46,48-49,52-54,56-59,62-63,68,71,74,76-80,83,87-88,91-92,95,97-101,104,107,111-116,119,122-125,127-130,133,136-137,147,150,152,155,159-160,163-165,169,175,178,180-181
src/agnocastlib/src/agnocast_multi_threaded_executor.cpp
                                              51       0     0%   9,13,15-17,19-20,25-26,29-33,36,38-41,44,48,51,53-55,58-60,64,66-67,71,74,77,79-80,82-83,87-88,91,96,100,103-104,107,114-117,120
src/agnocastlib/src/agnocast_publisher.cpp
                                              84       7     8%   7,9,20,23,28,30,32-38,42-43,50,55,57-62,65-72,77,81-88,91-92,94-97,99-102,104,107-108,112-113,119,123-132,135-136,139,142,144-149,152
src/agnocastlib/src/agnocast_single_threaded_executor.cpp
                                              19       0     0%   10-12,16,18-21,24,28-30,33,35-37,40-42
src/agnocastlib/src/agnocast_smart_pointer.cpp
                                              20       0     0%   5,7-15,19,21-29
src/agnocastlib/src/agnocast_subscription.cpp
                                              91       9     9%   10,12-15,17,20,24,27-29,31,33,35,37-42,44-49,51,54-61,64-67,69,71,74,77,81-84,86-92,95-97,99-102,105,108,112-117,119-124,126,128,131,135-136,138-139
src/agnocastlib/src/agnocast_topic_info.cpp
                                              16       0     0%   12,16-17,20-24,28-31,34-37
src/agnocastlib/src/agnocast_utils.cpp        25      23    92%   48,50
------------------------------------------------------------------------------
TOTAL                                        618     146    23%
------------------------------------------------------------------------------

@atsushi421 atsushi421 merged commit f380f3c into main Jan 24, 2025
4 checks passed
@atsushi421 atsushi421 deleted the add_tracepoints_for_caret branch January 24, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-build-test Run build-test in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants