-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tracepoints for CARET #327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9997f4c
to
1aadb38
Compare
1aadb38
to
1e57b61
Compare
と「実装の概要」資料にありますが、#328 においてプロセス内でも Agnocast 通信をできるように変更されています。このあたりはどうなりますか? |
Agnocastでプロセス内通信が行われている場合でも、それがプロセス外通信としてCARETのインタフェースで表示されてしまうのみで、現状の実装でresponse time, comm latency等は出せます! |
Koichi98
approved these changes
Jan 24, 2025
veqcc
approved these changes
Jan 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CARETで計測可能にするためのトレースポイント追加。
Related links
How was this PR tested?
Notes for reviewers
まだ不足しているトレースポイントがあったり、各トレースポイントの内容も改善の余地があるかもしれませんが、一旦主要メトリクスが計測できるようになったので、PRを出しました。CARETにマージするタイミングでこの改善はやります。