Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decrement borrowed_publisher_num before ros2 publish #334

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Koichi98
Copy link
Contributor

@Koichi98 Koichi98 commented Jan 24, 2025

Description

borrowed_publisher_numのデクリメントはros2 publishよりも前に行うことで、ros2 publish時に起きるシリアライゼーション等のメモリの確保が共有メモリ上に行われてしまうのを避けるようにしました。

Related links

How was this PR tested?

  • sample application (required)
  • Autoware (required)

Notes for reviewers

Signed-off-by: Koichi98 <koichi.imai.2@tier4.jp>
@Koichi98 Koichi98 requested review from atsushi421 and veqcc and removed request for atsushi421 January 24, 2025 05:34
@atsushi421 atsushi421 self-requested a review January 24, 2025 07:23
@atsushi421 atsushi421 added the run-build-test Run build-test in CI label Jan 24, 2025
Copy link

------------------------------------------------------------------------------
                           GCC Code Coverage Report
Directory: .
------------------------------------------------------------------------------
File                                       Lines    Exec  Cover   Missing
------------------------------------------------------------------------------
src/agnocastlib/include/agnocast.hpp           2       2   100%   
src/agnocastlib/include/agnocast_executor.hpp
                                               1       0     0%   38
src/agnocastlib/include/agnocast_publisher.hpp
                                              35      27    77%   62,85-86,95-97,108-109
src/agnocastlib/include/agnocast_smart_pointer.hpp
                                              53      50    94%   77,80-81
src/agnocastlib/include/agnocast_topic_info.hpp
                                              13      13   100%   
src/agnocastlib/src/agnocast.cpp              82      15    18%   22,24,27,30,32-34,36,39,42,44-50,54-55,58-62,66-67,71-74,77,80,82-85,88,91,93-94,96-97,102,104-106,109-112,115,117-123,125,138-139,150-151,154-156,161
src/agnocastlib/src/agnocast_component_container.cpp
                                              12       0     0%   5,7-8,11-13,16,18-20,22-23
src/agnocastlib/src/agnocast_component_container_mt.cpp
                                              28       0     0%   7,11-12,14-16,18-20,22-24,26-28,30,32-33,35-37,40,42,44-46,48-49
src/agnocastlib/src/agnocast_executor.cpp
                                              86       0     0%   10,12,14-16,18-20,24,26,29,31-32,35-39,42-45,47-48,51-53,55-58,61-62,67,70,73,75-79,82,86-87,90-91,94,96-100,103,106,110-115,118,121-124,126-129,132,135-137,140,142,145,149-150,153-156,159,162,164-165
src/agnocastlib/src/agnocast_multi_threaded_executor.cpp
                                              51       0     0%   9,13,15-17,19-20,25-26,29-33,36,38-41,44,48,51,53-55,58-60,64,66-67,71,74,77,79-80,82-83,87-88,91,96,100,103-104,107,114-117,120
src/agnocastlib/src/agnocast_publisher.cpp
                                              84       7     8%   7,9,20,23,28,30,32-38,42-43,50,55,57-62,65-72,77,81-88,91-92,94-97,99-102,104,107-108,112-113,119,123-132,135-136,139,142,144-149,152
src/agnocastlib/src/agnocast_single_threaded_executor.cpp
                                              19       0     0%   10-12,16,18-21,24,28-30,33,35-37,40-42
src/agnocastlib/src/agnocast_smart_pointer.cpp
                                              20       0     0%   5,7-15,19,21-29
src/agnocastlib/src/agnocast_subscription.cpp
                                              91       9     9%   10,12-15,17,20,24,27-29,31,33,35,37-42,44-49,51,54-61,64-67,69,71,74,77,81-84,86-92,95-97,99-102,105,108,112-117,119-124,126,128,131,135-136,138-139
src/agnocastlib/src/agnocast_topic_info.cpp
                                              16       0     0%   12,16-17,20-24,28-31,34-37
src/agnocastlib/src/agnocast_utils.cpp        25      23    92%   48,50
------------------------------------------------------------------------------
TOTAL                                        618     146    23%
------------------------------------------------------------------------------

@Koichi98 Koichi98 merged commit f161095 into main Jan 24, 2025
5 checks passed
@Koichi98 Koichi98 deleted the fix/dec_brw_pub_num_earlier branch January 24, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-build-test Run build-test in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants