test: add E2E test for 1pub-1sub with ros2sub #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atsushi421 <atsushi.yano.2@tier4.jp>
|
テスト実行中にログが出続けると思うのですが、これらのログに全体のテスト何個のうち何個目のテストを実行中なのかとか、テストの内容とかを含めることは可能ですか？ |
可能です！テストの内容はconfigの内容を出すでOKですか？ |
いいと思います！ |
追加しました！ 12f29ae |
atsushi421
changed the title
atsushi421
changed the title
atsushi421
changed the title
|
現状failしたテストがあったらそこでテストが止まると思うのですが、failしてもそのまま他のテストも実行するようなoptionがあると嬉しいかもです！デフォルトは停止がいいと思うのですが、failするのを確認したのちに他のテストが落ちる/落ちないことを確認することでデバッグ情報が増えるので需要があるかと思いました。 |
|
Koichi98
reviewed
Jan 31, 2025
Koichi98
reviewed
Jan 31, 2025
Co-authored-by: Koichi Imai <45482193+Koichi98@users.noreply.github.com>
Co-authored-by: Koichi Imai <45482193+Koichi98@users.noreply.github.com>
veqcc
previously approved these changes
Feb 3, 2025
Koichi98
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://docs.google.com/spreadsheets/d/17tKod2f6-dnB6F0oh8RyAoWxezcKPx9DlzO1rrgeZik/edit?gid=0#gid=0 を実装しました。実行に時間がかかるので、現状はCIに組み込んでいません。
Related links
How was this PR tested?
bash scripts/e2e_test_1to1_with_ros2subNotes for reviewers
launchファイルでyamlを読み込むようになっているのは、launchファイルの引数のParseとlaunch_testingを共存させるのが困難だったためです。