refactor: uninstall agnocast_heaphook before test_and_create_report #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
今井くんと口頭で話しましたが、 |
veqcc
approved these changes
Jan 31, 2025
Koichi98
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
agnocast-heaphookがインストールされている、かつ、kmodがinsmodされていない状態だと、単体テストがfailしてしまうので、もしagnocast-heaphookがインストールされている場合は
となるようにスクリプトを修正しました。ついでにテスト結果の詳細もコンソールに出るようにしました。
Related links
https://star4.slack.com/archives/C07FL8616EM/p1738287186688019
How was this PR tested?
ローカルで動作確認。
Notes for reviewers