-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agnocastlib): use worker thread for ros2 publisher #356
Conversation
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
|
|
recommended: worker thread + conditional variable |
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Co-authored-by: atsushi yano <55824710+atsushi421@users.noreply.github.com>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
The problem was already fixed with your implementation on Publisher destructor!
|
コンフリクト解決お願いします 🙇 |
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@Koichi98 |
|
Description
This PR changes to use worker thread for publishing ROS 2 messages, in order to reduce the latency of
publish
.Major features are:
mq
to notify that ROS 2 publish should be doneRelated links
TIER IV INTERNAL
How was this PR tested?
bash scripts/e2e_test_1to1_with_ros2sub
bash scripts/e2e_test_2to2
Notes for reviewers
There is a problem around termination when std::thread are used.
It will be solved later by @Koichi98