Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kmod): update kernel module macros #434

Merged
merged 4 commits into from
Feb 27, 2025
Merged

fix(kmod): update kernel module macros #434

merged 4 commits into from
Feb 27, 2025

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Feb 27, 2025

Description

  • updated MAX_SUBSCRIBER_NUM from 8 to 16, considering Autoware topics
  • updated comments for MAX_... macros
  • moved MAX_MAP_NUM from header to .c file

Related links

How was this PR tested?

  • Autoware (required)
  • bash scripts/e2e_test_1to1_with_ros2sub (required)
  • bash scripts/e2e_test_2to2 (required)
  • sample application

Notes for reviewers

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@veqcc veqcc changed the title fix(kmod): refactor comments fix(kmod): update kernel module macros Feb 27, 2025
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@veqcc veqcc marked this pull request as ready for review February 27, 2025 02:18
@atsushi421 atsushi421 added the run-build-test Run build-test in CI label Feb 27, 2025
Copy link

------------------------------------------------------------------------------
                           GCC Code Coverage Report
Directory: .
------------------------------------------------------------------------------
File                                       Lines    Exec  Cover   Missing
------------------------------------------------------------------------------
src/agnocastlib/include/agnocast.hpp           4       4   100%   
src/agnocastlib/include/agnocast_callback_info.hpp
                                              25      22    88%   91,93-94
src/agnocastlib/include/agnocast_executor.hpp
                                               1       1   100%   
src/agnocastlib/include/agnocast_publisher.hpp
                                              89      57    64%   95,114-116,127,133,137,145-147,150,154-156,163-164,167-169,172-173,176,181,208-209,214-215,218-220,224-225
src/agnocastlib/include/agnocast_smart_pointer.hpp
                                              47      47   100%   
src/agnocastlib/src/agnocast.cpp              57      10    17%   19,22,24-30,34-35,38-42,46-47,51-54,57,60,62,65,67-68,73,75-77,80-83,86,88-94,97,107-108
src/agnocastlib/src/agnocast_callback_info.cpp
                                              17      14    82%   29-31
src/agnocastlib/src/agnocast_component_container.cpp
                                              12       0     0%   5,7-8,11-13,16,18-20,22-23
src/agnocastlib/src/agnocast_component_container_mt.cpp
                                              28       0     0%   7,11-12,14-16,18-23,25-27,29,31-32,34-36,39,41,43-45,47-48
src/agnocastlib/src/agnocast_executor.cpp
                                              99      72    72%   20-21,49,60-62,80-83,86,102-104,116-119,122,129-131,136-139,169
src/agnocastlib/src/agnocast_multi_threaded_executor.cpp
                                              55       0     0%   9,13,15-17,19-20,25-26,29-33,36,38-41,44,48,51,53-55,58-60,64,66-67,71,73-74,77,79-80,82-83,87-88,91,96,100,102-104,107,109-110,118-121,124
src/agnocastlib/src/agnocast_publisher.cpp
                                              56       7    12%   10,12,23,26,31,35,37-46,49,52,57-64,73-74,76-79,81-84,86,91,95-96,101,104,106-111,114
src/agnocastlib/src/agnocast_single_threaded_executor.cpp
                                              25      21    84%   16,26-28
src/agnocastlib/src/agnocast_smart_pointer.cpp
                                              18       0     0%   6,9-16,20,23-30
src/agnocastlib/src/agnocast_subscription.cpp
                                              52       9    17%   6-7,9,12,15,19-30,33-37,40,43,47-52,54-59,61,63,66,70-71,73-74
src/agnocastlib/src/agnocast_utils.cpp        29      26    89%   63,65-66
------------------------------------------------------------------------------
TOTAL                                        614     290    47%
------------------------------------------------------------------------------

@veqcc veqcc merged commit aae71fa into main Feb 27, 2025
4 checks passed
@veqcc veqcc deleted the fix/kmod_comments branch February 27, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-build-test Run build-test in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants