Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for CallbackGroupType::Reentrant #450

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix: for CallbackGroupType::Reentrant #450

merged 2 commits into from
Feb 28, 2025
+13 −5

Conversation

atsushi421
Copy link
Contributor

@atsushi421 atsushi421 commented Feb 28, 2025 •
edited
Loading

Description

This fixes the bug that Agnocast's executor doesn't consider CallbackGroupType::Reentrant.

Related links

How was this PR tested?

  • Autoware (required) -> skip
  • bash scripts/e2e_test_1to1_with_ros2sub (required)
  • bash scripts/e2e_test_2to2 (required)
  • sample application

Notes for reviewers

As far as I examined, can_be_taken_from is never false in Reentrant, but I am also checking in Reentrant just to be sure.

@atsushi421
fix: for CallbackGroupType::Reentrant
571f568 
Signed-off-by: atsushi421 <atsushi.yano.2@tier4.jp>
@atsushi421 atsushi421 added the run-build-test Run build-test in CI label Feb 28, 2025
@atsushi421 atsushi421 merged commit 61cd342 into main Feb 28, 2025
4 checks passed
@atsushi421 atsushi421 deleted the fix_for_reentrant branch February 28, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veqcc veqcc veqcc approved these changes

@Koichi98 Koichi98 Awaiting requested review from Koichi98 Koichi98 is a code owner

Assignees

@atsushi421 atsushi421

Labels
run-build-test Run build-test in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushi421 @veqcc