Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update aip_x1 to v2024.7 #330

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Oct 8, 2024

related link
#237

@Autumn60 Autumn60 requested a review from 1222-takeshi October 8, 2024 08:11
@Autumn60 Autumn60 marked this pull request as ready for review October 8, 2024 08:12
@Autumn60 Autumn60 removed the request for review from 1222-takeshi October 8, 2024 08:14
1222-takeshi and others added 8 commits October 8, 2024 17:15
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(velodyne_node_container): fix param load failure

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(diagnostic_aggregator): update sensor kit param (#22) (#23)

* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator

fix: add vehicle_velocity_converter.launch (#146)

fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option and add gnss imu

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add GNSS

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: change topic name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add node alive monitoring

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update ground_segmentation param

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: remove use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add cropbox filter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add diag of gyro_bias_validator

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: comment out for avoid no diag stale

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss.launch for x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: use pointcloud_container

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix: change topic name for ground segmentation

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1_launch): rename some topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1, aip_x1_1): use interpolate

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(velodyne_node_container): use distortion_corrector

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(ground_segmentation): change crop parameter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(obstacle_segmentation): relax ground_segmentation threshold

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore(ground_segmentation): change parameter name (#229)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore(ground_segmentation): add missing parameters (#231)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>

feat: use nebula driver for aip_x1_1 sensor configuration (#235)

* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore: remove aip_x1 and rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: remove unused file and fix bug

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

ci(pre-commit): autofix

fix: diag list

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix cancat lidar topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
* add enable_blockage_diag argument to lidar.launch.xml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
* delete unnecessary arg passing

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* fix gnss_poser param

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* Adjust gnss launching condition

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* fix invalid tag usage

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
replace use_awsim to use_gnss

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
@Autumn60 Autumn60 force-pushed the add-XT32-model_rebase_main branch from cd42d2a to e6cf031 Compare October 8, 2024 08:15
@Autumn60 Autumn60 requested a review from 1222-takeshi October 8, 2024 08:18
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Autumn60 Autumn60 merged commit 6a26e82 into tier4/universe Oct 15, 2024
10 of 11 checks passed
@Autumn60 Autumn60 deleted the add-XT32-model_rebase_main branch October 15, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants