feat(aip_x2_gen2_launch): add launcher for ARS548 to pass some missing arguments #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
This reverts commit 87b5351.
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
changed the title
TomohitoAndo
changed the title
TomohitoAndo
requested review from
yabuta,
muraki-t4,
vividf and
kotaro-hihara
kotaro-hihara
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RADARのパラメータが正しく渡されていない問題があったため、
aip_x2_gen2_launchに新たにRADAR用のlaunchを追加して、パラメータを渡すように修正。Related:
Tests
Autowareを起動し、
sensor_ip,frame_idなどのパラメータが正しく渡されていることを確認detection_pointsのframe_idが書き換わっていることを確認
logging simulatorで各RADARのtopicにdetection pointsがpublishされていることを確認
