Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): huge tracking object bug fix for x2 #1314

Merged

Conversation

technolojin
Copy link

@technolojin technolojin commented May 31, 2024

Description

Catch-up of old PRs, cherry-pick of the fix autowarefoundation#7159

Bug ticket: https://tier4.atlassian.net/browse/RT0-31411

Tests performed

Want to be checked in X2 environment.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin requested review from 0x126 and dai0912th May 31, 2024 04:31
@technolojin technolojin marked this pull request as ready for review May 31, 2024 04:32
@technolojin technolojin changed the title fix(multi_object_tracker): mot huge object bug fix for x2 fix(multi_object_tracker): huge tracking object bug fix for x2 May 31, 2024
Copy link

@dai0912th dai0912th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have regression test in X2 environment before this PR merge into beta/v0.19.1, but I agree to merge it without that test due to limited remaing time until X2 v3.0.0 release date.

@technolojin
Copy link
Author

@dai0912th
Thank you for your confirmation. Shall I merge it now? Or will you merge it after some test?

@dai0912th
Copy link

@dai0912th Thank you for your confirmation. Shall I merge it now? Or will you merge it after some test?

@technolojin Please merge it when you are ready to merge. X2 test will be started after PR merge by myside.

@technolojin technolojin merged commit 4b1f18e into tier4:beta/v0.19.1 May 31, 2024
12 of 13 checks passed
saka1-s added a commit that referenced this pull request Jun 5, 2024
* Revert "fix(multi_object_tracker): calculation of detection delay diagnostics (#1317)"

This reverts commit f45652e.

* Revert "fix(multi_object_tracker): huge tracking object bug fix for x2 (#1314)"

This reverts commit 4b1f18e.
@technolojin technolojin deleted the fix/x2-fix-mot-huge-object-bug branch July 11, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants