Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sp develop remove non approved change #1611

Conversation

technolojin
Copy link

Description

This reverts commit 5de95b0.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin marked this pull request as ready for review October 29, 2024 06:52
@technolojin technolojin self-assigned this Oct 29, 2024
@technolojin technolojin changed the title beta/v0.19.1 sp develop remove non approved change sp develop remove non approved change Oct 29, 2024
@technolojin technolojin enabled auto-merge (squash) October 29, 2024 06:53
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin changed the title sp develop remove non approved change fix: sp develop remove non approved change Oct 29, 2024
@technolojin technolojin merged commit 4fb0d67 into tier4:beta/v0.19.1-sp-develop Oct 29, 2024
12 of 15 checks passed
@technolojin technolojin deleted the beta/v0.19.1-sp-develop-remove-non-approved-change branch October 29, 2024 06:54
Copy link

saka1-s added a commit that referenced this pull request Oct 31, 2024
* feat(lane_change): cancel hysteresis (autowarefoundation#6288)

* feat(lane_change): cancel hysteresis

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Update documentation

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix the explanation of the hysteresis count

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Add parked parked RSS

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* support new perception_reproducer

Signed-off-by: temkei.kem <1041084556@qq.com>

* move files

Signed-off-by: temkei.kem <1041084556@qq.com>

* remove old files.

Signed-off-by: temkei.kem <1041084556@qq.com>

* fix pre-commit err

Signed-off-by: temkei.kem <1041084556@qq.com>

* style(pre-commit): autofix

* feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity (#1571)

Refactor turn signal decider logic and add support for detecting turn signals in turn lanes

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* fix a small bug about perception reproducer

* style(pre-commit): autofix

* feat(out_of_lane): ignore lanelets beyond the last path point (#1554)

* feat(out_of_lane): ignore lanelets beyond the last path point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(behavior_velocity_run_out_module): exclude obstacle crossing ego… (#1574)

feat(behavior_velocity_run_out_module): exclude obstacle crossing ego back line (autowarefoundation#6680)

* add method to ignore target obstacles that cross ego cut lane



* WIP add debug support



* add params and finish debug marker



* change lane to line



* use autoware utils to get the cut line



* simplify code wit calcOffsetPose



* Update readme and eliminate unused code



* update readme



* eliminate unused function



* readme



* comments and readme



* eliminate unused include



* typo



* rename param for consistency



* change lane to line for consistency



* rename for clarity, add brief



* fix indentation



* update description



* lane ->line



* lane -> line



---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix(lane_change): change stopping logic (RT0-33761) (#1581)

* RT0-33761 fix lane change stopping logic

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* copied from awf main tested implementation

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* doxygen comment

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Update planning/behavior_path_lane_change_module/src/utils/utils.cpp

Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com>

* perf: PR 7237

autowarefoundation#7237

* perf RP8406

autowarefoundation#8406

* perf PR 8416

* perf PR 8427

* perf PR 8413

* tool PR 8456

* perf PR 8461

* perf PR 8388

* perf PR 8467

* perf PR 8471

* perf PR 8490

* perf PR 8751

* chore: fix format

* perf PR 8657

* feat: improve lanelet search logic in getPredictedReferencePath()

* sp develop remove non approved change (#1611)

Revert "feat: improve lanelet search logic in getPredictedReferencePath()"

This reverts commit 5de95b0.

* feat PR 8811

* fix PR 8973

* feat: improve lanelet search logic in getPredictedReferencePath()

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: temkei.kem <1041084556@qq.com>
Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: temkei.kem <1041084556@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp>
Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com>
Co-authored-by: Shohei Sakai <saka1s.jp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants