Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_pointcloud_preprocessor): reuse collectors to reduce creation of collector and timer (#10074) #1868

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

SakodaShintaro
Copy link

@SakodaShintaro SakodaShintaro commented Feb 25, 2025

Description

cherry-pick

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…eation of collector and timer (autowarefoundation#10074)

* feat: reuse collectors

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: remove for-loop to find_if

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: remove set period

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: remove oldest timestamp

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix managing collector list logic

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix logging

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* feat: change to THROTTLE

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* feat: initialize required number of collectors when the node start

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix init collector

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix grammar

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

---------

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@SakodaShintaro SakodaShintaro self-assigned this Feb 25, 2025
@SakodaShintaro SakodaShintaro requested a review from rej55 February 25, 2025 09:29
@SakodaShintaro SakodaShintaro marked this pull request as ready for review February 25, 2025 09:29
@SakodaShintaro SakodaShintaro merged commit 998ad18 into beta/v0.41 Feb 25, 2025
29 of 31 checks passed
@SakodaShintaro SakodaShintaro deleted the cherry-pick/10074 branch February 25, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants