Skip to content

feat(control_validator, tier4_diagnostics): sync upstream #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Apr 17, 2025

Description

beta/v0.41のcontrol_validator関係の設定をv0.41からv0.44相当に更新する変更です。
リファクタリングを含みますので、変更自体はそこそこの大きさがありますが、パイプラインからは独立しているモジュールですので、影響は限定的かと想定しています。

How was this PR tested?

psimにおいて、以下を確認しました。

  • /diagnosticsの内容がv0.44相当のものになっていること
  • 坂道で走らせても、誤検知が発生しないこと
  • シミュレータの車両モデルを意図的壊すとそれらしいMRM停止ができること

Related links

launch: tier4/autoware_launch#838

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

satoshi-ota and others added 7 commits April 17, 2025 12:12
…utowarefoundation#10240)

* feat(control_validator): add diag to check control component latency

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: missing param

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
…10326)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
… increment bug (autowarefoundation#10355)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review April 21, 2025 12:59
@yuki-takagi-66
Copy link
Author

yuki-takagi-66 commented Apr 21, 2025

@rej55 追加修正 (autowarefoundation#10508 ) を取り込み、PRを再openしました。お願いします。

Copy link

@rej55 rej55 merged commit 73645f2 into beta/v0.41 Apr 23, 2025
27 of 31 checks passed
@rej55 rej55 deleted the bv041+control_validator_044 branch April 23, 2025 02:53
yuki-takagi-66 added a commit that referenced this pull request May 9, 2025
* feat(control_validator): add diag to check control component latency (autowarefoundation#10240)

* feat(control_validator): add diag to check control component latency

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: missing param

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(control_validator)!: add overrun check (autowarefoundation#10236)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

* feat(control_validator)!: add acceleration check (autowarefoundation#10326)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

* fix(control_validator): fix sign miss and add code test (autowarefoundation#10341)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

* fix(control validator): combine callback functions to fix error count increment bug (autowarefoundation#10355)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

* refactor(control validaor): refactor control_validator (autowarefoundation#10363)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

* feat(control_validator): add over run estimation feature (autowarefoundation#10422)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* fix(control_validator): fix less trajectory point check (autowarefoundation#10508)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants