From e8e908d8f772133e5c8c9f2a18fd71d762b28712 Mon Sep 17 00:00:00 2001 From: "takeshi.iwanari" Date: Thu, 1 Feb 2024 10:51:16 +0900 Subject: [PATCH] fix(trace_validation_failure): fix stuck due to value_object comparison Signed-off-by: takeshi.iwanari --- report/report_validation/index.js | 3 ++- .../make_report_trace_validation_failure.py | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/report/report_validation/index.js b/report/report_validation/index.js index cf9d8112..eed9ba39 100644 --- a/report/report_validation/index.js +++ b/report/report_validation/index.js @@ -233,7 +233,8 @@ for (let componentpair in summary_topic_dict_component_pair_metrics) { let cnt_total = cnt_pass + cnt_failed; let class_name = "pass"; if (cnt_not_measured > 0) { - class_name = "not_measured"; + // Do not show not_measured because expectation list contains old topics/calbacks + // class_name = "not_measured"; } if (cnt_failed > 0) { class_name = "failed"; diff --git a/report/trace_validation_failure/make_report_trace_validation_failure.py b/report/trace_validation_failure/make_report_trace_validation_failure.py index 0fefd9bb..f7964d53 100644 --- a/report/trace_validation_failure/make_report_trace_validation_failure.py +++ b/report/trace_validation_failure/make_report_trace_validation_failure.py @@ -72,8 +72,8 @@ def search_publishers(arch: Architecture, topic_name: str, subscribe_node_name: for comm in arch.communications: if comm.topic_name not in search_publishers.comm_dict: search_publishers.comm_dict[comm.topic_name] = [] - if comm not in search_publishers.comm_dict[comm.topic_name]: - search_publishers.comm_dict[comm.topic_name].append(comm) + # if comm not in search_publishers.comm_dict[comm.topic_name]: # Assume duplicated comm doesn't exist. this line make the performance slow + search_publishers.comm_dict[comm.topic_name].append(comm) if topic_name not in search_publishers.comm_dict: return [] publisher_list = [comm.publish_node_name for comm in search_publishers.comm_dict[topic_name] if comm.subscribe_node_name == subscribe_node_name]