Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace_validation_failure): fix stuck due to value_object comparison #158

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix(trace_validation_failure): fix stuck due to value_object comparison #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion report/report_validation/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var cy = (window.cy = cytoscape({

Check warning on line 1 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (cytoscape)
container: document.getElementById("cy"),

style: [
Expand All @@ -22,15 +22,15 @@
{
selector: ".result",
style: {
"text-valign": "center",

Check warning on line 25 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (valign)
"text-halign": "right",

Check warning on line 26 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (halign)
},
},
{
selector: ".external",
style: {
"text-valign": "top",

Check warning on line 32 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (valign)
"text-halign": "center",

Check warning on line 33 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (halign)
shape: "round-rectangle",
width: "10",
height: "10",
Expand Down Expand Up @@ -184,9 +184,9 @@
cy.panningEnabled(false);
cy.boxSelectionEnabled(false);
cy.nodes().lock();
cy.nodes().unselectify();

Check warning on line 187 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (unselectify)
cy.edges().lock();
cy.edges().unselectify();

Check warning on line 189 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (unselectify)

// Update using callback validation result
let metrics = "FREQUENCY";
Expand All @@ -198,7 +198,7 @@
let cnt_total = cnt_pass + cnt_failed;
let class_name = "pass";
if (cnt_not_measured > 0) {
// Do not show not_measured because expectation list contains old topics/calbacks

Check warning on line 201 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (calbacks)
// class_name = "not_measured";
}
if (cnt_failed > 0) {
Expand All @@ -223,8 +223,8 @@
});

// Update using topic validation result
for (let componentpair in summary_topic_dict_component_pair_metrics) {

Check warning on line 226 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (componentpair)
let pub_component_name = componentpair.split("-")[0];

Check warning on line 227 in report/report_validation/index.js

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (componentpair)
let sub_component_name = componentpair.split("-")[1];
let cnt_pass = summary_topic_dict_component_pair_metrics[componentpair][metrics].cnt_pass;
let cnt_failed = summary_topic_dict_component_pair_metrics[componentpair][metrics].cnt_failed;
Expand All @@ -233,7 +233,8 @@
let cnt_total = cnt_pass + cnt_failed;
let class_name = "pass";
if (cnt_not_measured > 0) {
class_name = "not_measured";
// Do not show not_measured because expectation list contains old topics/calbacks
// class_name = "not_measured";
}
if (cnt_failed > 0) {
class_name = "failed";
Expand Down
4 changes: 2 additions & 2 deletions report/trace_validation_failure/make_report_trace_validation_failure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ def search_publishers(arch: Architecture, topic_name: str, subscribe_node_name:
for comm in arch.communications:
if comm.topic_name not in search_publishers.comm_dict:
search_publishers.comm_dict[comm.topic_name] = []
if comm not in search_publishers.comm_dict[comm.topic_name]:
search_publishers.comm_dict[comm.topic_name].append(comm)
# if comm not in search_publishers.comm_dict[comm.topic_name]: # Assume duplicated comm doesn't exist. this line make the performance slow
search_publishers.comm_dict[comm.topic_name].append(comm)
if topic_name not in search_publishers.comm_dict:
return []
publisher_list = [comm.publish_node_name for comm in search_publishers.comm_dict[topic_name] if comm.subscribe_node_name == subscribe_node_name]
Expand Down
Loading