Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_auto_control_msgs): replace autoware_auto_control_msgs with autoware_control_msgs #61

Closed
wants to merge 1 commit into from

Conversation

xmfcx
Copy link

@xmfcx xmfcx commented May 17, 2023

PR Type

  • Refactor

Related Links

Description

Replace all usages of

Review Procedure

Make sure it compiles with the rest of the Autoware once it is merged along with the Autoware Universe PR:

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code follows [coding guidelines][coding-guidelines]
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows [coding guidelines][coding-guidelines]
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write [release notes][release-notes]

@xmfcx
Copy link
Author

xmfcx commented May 17, 2023

@isamu-takagi @mitsudome-r could you review this too?

@isamu-takagi
Copy link
Collaborator

@xmfcx @TakaHoribe @TomohitoAndo @aohsato
Could you ask the maintainer for a review? It's probably good, but I'm not familiar with this package.

@xmfcx
Copy link
Author

xmfcx commented May 17, 2023

@tkimura4 you seem to be a maintainer of this package, could you look into this too? (I cannot assign reviewers.)

@tkimura4 tkimura4 requested review from shmpwk and tkimura4 May 17, 2023 13:53
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good.

@xmfcx xmfcx force-pushed the refactor-control-msgs branch from e39870a to a02a655 Compare June 20, 2023 15:37
…sgs with autoware_control_msgs

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx
Copy link
Author

xmfcx commented Mar 7, 2024

I'm closing all of my message migration PRs.

@xmfcx xmfcx closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants