Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add autoware_ prefix to lanelet2_extension #1300

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat: add autoware_ prefix to lanelet2_extension #1300

merged 4 commits into from
Jun 25, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jun 25, 2024

youtalk added 2 commits June 25, 2024 13:57
@youtalk
add autoware_ prefix
a3591f0 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
update repos
6501e63 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Jun 25, 2024
@youtalk youtalk marked this pull request as ready for review June 25, 2024 05:07
@youtalk youtalk requested a review from HansRobo June 25, 2024 05:07
@youtalk youtalk changed the title Goodbye autoware common feat: add autoware_ prefix to lanelet2_extension Jun 25, 2024
This was referenced Jun 25, 2024
Closed
Closed
@youtalk
re-add autoware_common
a7c0468 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
Copy link
Member Author

youtalk commented Jun 25, 2024

To accommodate both the deprecated lanelet2_extension and the new autoware_lanelet2_extension. The autoware_common repository has been changed to a branch that removes autoware_cmake, autoware_lint_common, and autoware_utils. a7c0468
@HansRobo I think it'll be mergable. Please reveiw again.

@hakuturu583 hakuturu583 added bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 and removed bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Jun 25, 2024
@HansRobo
Copy link
Member

@hakuturu583 This pull-request is not for master.

@youtalk youtalk requested a review from HansRobo June 25, 2024 08:08
HansRobo
HansRobo approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for build CI

@HansRobo HansRobo removed the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Jun 25, 2024
@HansRobo
Copy link
Member

Build is OK.
(The CI is failed due to tests originally failures in target branch)

@HansRobo HansRobo merged commit e073325 into tier4:RJD-736/autoware_msgs_support Jun 25, 2024
1 of 4 checks passed
@mitsudome-r mitsudome-r mentioned this pull request Jul 3, 2024
Closed
@HansRobo HansRobo mentioned this pull request Jul 3, 2024
Merged
@youtalk youtalk deleted the goodbye-autoware-common branch July 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansRobo HansRobo HansRobo approved these changes

@kielczykowski-rai kielczykowski-rai Awaiting requested review from kielczykowski-rai

Assignees

@youtalk youtalk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youtalk @HansRobo @hakuturu583