-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce build time by suppressing template instantiation #1419
Draft
shouth
wants to merge
25
commits into
master
Choose a base branch
from
feature/faster-template-instantiation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+415
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late-instantiation
…late-instantiation
…late-instantiation
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
|
yamacir-kit
requested changes
Oct 25, 2024
openscenario/openscenario_interpreter/include/openscenario_interpreter/reader/attribute.hpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/include/openscenario_interpreter/reader/attribute.hpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/include/openscenario_interpreter/reader/attribute.hpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/include/openscenario_interpreter/reader/element.hpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/include/openscenario_interpreter/reader/element.hpp
Outdated
Show resolved
Hide resolved
…late-instantiation
Co-authored-by: Tatsuya Yamasaki <httperror@404-notfound.jp>
Co-authored-by: Tatsuya Yamasaki <httperror@404-notfound.jp>
Co-authored-by: Tatsuya Yamasaki <httperror@404-notfound.jp>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR reduces the build time of
openscenario_interpreter
by suppressing heavy template instantiation.Background
openscenario_interpreter
heavily relies on templated components. These components are typically instantiated and optimized per translation unit, which can lead to longer build times.Details
Added several explicit instantiations to
readAttribute
and moved thesubstitute()
function used internally to the cpp file. No changes were made to the algorithm itself.Added several explicit instantiations to
readElement
. Additionally, thechoice()
function was made non-template and its implementation was moved to the cpp file. No changes were made to the algorithm itself. Due to this change, the arguments of thechoice()
function have changed from "variadic arguments ofstd::pair
" to "std::unordered_map
," resulting in a slight modification in how the arguments are described in the places wherechoice()
is called. Most of the changes in the diffs are due to this modification.References
N/A
Destructive Changes
N/A
Known Limitations
N/A