Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactors and small fixes for ParameterValueDistribution-related codes (stochastic) #1510

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jan 21, 2025

Description

Abstract

  • Change way to manage a shared resource for stochastic parameter distributions
  • Fix member element names
  • Improve detailed implementation

Background

There are a large diff in #1253.
This pull-request is a part of it.

Details

Change way to manage a shared resource for stochastic parameter distributions

Use Scope::random_engine instead of Scope::seed as shared resource for stochastic parameter distributions.

Fixed member element names

class wrong member name fixed member name
PoissonDistribution range Range
NormalDistribution range Range
UniformDistribution range Range
HistogramBin range Range
ParameterValueDistributionDefinition parameterValueDistribution ParameterValueDistribution

Improve detailed implementation

Stop using XXAdaptor for member initialization

  • Histogram
  • ProbabilityDistributionSet

References

Destructive Changes

Known Limitations

In this pull-request, tests are out-of-scope.

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Copy link

@HansRobo HansRobo changed the title refactors and small fixes for ParameterValueDistribution-related codes refactors and small fixes for ParameterValueDistribution-related codes (stochastic) Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant