Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HdMapUtils refactor lanelet_wrapper::route #1531

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

abco20
Copy link
Contributor

@abco20 abco20 commented Feb 17, 2025

Description

Abstract

This is the partial PR of the HdMapUtils refactor (PR 2/6) ( #1478 )

Details

Replace usage of HdMapUtils::getRoute with non-member function route::route

References

Destructive Changes

None.

Known Limitations

None.

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@yamacir-kit yamacir-kit added bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor labels Feb 17, 2025
@hakuturu583 hakuturu583 added bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 bump major If this pull request merged, bump major version of the scenario_simulator_v2 and removed bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Feb 20, 2025
@hakuturu583 hakuturu583 merged commit 0845ce1 into master Feb 20, 2025
26 checks passed
@github-actions github-actions bot deleted the refactor/lanelet_wrapper_route branch February 20, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump major If this pull request merged, bump major version of the scenario_simulator_v2 refactor wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants