Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push latest tag along with versioned Docker images. #1535

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

takanotaiga
Copy link
Member

@takanotaiga takanotaiga commented Feb 25, 2025

Abstract

This Pull Request updates the GitHub Actions workflow to modify the tagging behavior for Docker images in the scenario_simulator_v2 repository. The changes ensure that the latest version tags are consistently applied to the traffic_simulator and humble images.

Background

Previously, the workflow tagged images with version-specific identifiers but did not consistently apply the latest tag. This omission could lead to confusion when pulling the most up-to-date images. This update adds the latest tag to improve version tracking and deployment consistency.

Details

  • Updated the tags section in the GitHub Actions workflow to include:
  • ghcr.io/tier4/scenario_simulator_v2:traffic_simulator_latest in the traffic_simulator job.
  • ghcr.io/tier4/scenario_simulator_v2:latest in the humble job.
  • Ensured that the push: true setting remains active for these changes to take effect.

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

@takanotaiga takanotaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Feb 25, 2025
@takanotaiga takanotaiga self-assigned this Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@takanotaiga takanotaiga marked this pull request as ready for review February 25, 2025 08:02
@hakuturu583 hakuturu583 merged commit 95ad312 into master Feb 26, 2025
9 checks passed
@github-actions github-actions bot deleted the feature/push-latest-docker-tag branch February 26, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants