-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RJD-1057: Reorganize ostream operators #1539
Conversation
Co-authored-by: Dawid Moszynski <dawid.moszynski@robotec.ai> Co-authored-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.005730999999999999983124610026) is greaterThan 0.005?}, {"avoid startup": Is the simulation time (= 2.799999999999997601918266809662) is greaterThan 1.000000000000000000000000000000?}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do the regression test and review. After that, I'll approve this.
(There is nothing that needs to be changed at this time. This is just for block merging before test.)
|
Description
Abstract
This is a partial pull request of #1334.
Background
std::ostream & operator<<
are defined inhelper.[ch]pp
. However, this filename is not intuitive.Also, output of these operators are ambiguous.
Details
Quoted from #1334.
In addition, this PR will update test related to changes.
References
#1334
Destructive Changes
Output from operators are changed. We may need to fix programs that use output.