Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJD-1057: Reorganize ostream operators #1539

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

f0reachARR
Copy link
Contributor

Description

Abstract

This is a partial pull request of #1334.

Background

std::ostream & operator<< are defined in helper.[ch]pp. However, this filename is not intuitive.
Also, output of these operators are ambiguous.

Details

Quoted from #1334.

Ostream helpers
All existing operators std::ostream & operator<< have been moved from file helper.[ch]pp to a dedicated file ostream_helper.[ch]pp.
In addition many more operators have been added for the types

  • traffic_simulator_msgs::msg::LaneletPose
  • traffic_simulator_msgs::msg::EntitySubtype
  • traffic_simulator_msgs::msg::Axle
  • traffic_simulator_msgs::msg::Axles
  • traffic_simulator_msgs::msg::BoundingBox
  • traffic_simulator_msgs::msg::Performance
  • traffic_simulator_msgs::msg::VehicleParameters

In addition, this PR will update test related to changes.

References

#1334

Destructive Changes

Output from operators are changed. We may need to fix programs that use output.

Co-authored-by: Dawid Moszynski <dawid.moszynski@robotec.ai>
Co-authored-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
Copy link

github-actions bot commented Feb 28, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@f0reachARR f0reachARR marked this pull request as ready for review February 28, 2025 05:17
@f0reachARR f0reachARR changed the title RJD-1057: Reorganize ostream helper operators RJD-1057: Reorganize ostream operators Feb 28, 2025
Copy link

Failure optional scenarios

Note

This is an experimental check and does not block merging the pull-request.
But, please be aware that this may indicate a regression.

scenario failed: execution_time_test
      <failure type="SimulationFailure" message="CustomCommandAction typed &quot;exitFailure&quot; was triggered by the named Conditions {&quot;update time checker&quot;, &quot;avoid startup&quot;}: {&quot;update time checker&quot;: Is the /simulation/interpreter/execution_time/update (= 0.005730999999999999983124610026) is greaterThan 0.005?}, {&quot;avoid startup&quot;: Is the simulation time (= 2.799999999999997601918266809662) is greaterThan 1.000000000000000000000000000000?}" />

Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do the regression test and review. After that, I'll approve this.
(There is nothing that needs to be changed at this time. This is just for block merging before test.)

@HansRobo HansRobo self-assigned this Feb 28, 2025
@HansRobo HansRobo added refactor wait for regression test bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 and removed refactor labels Mar 3, 2025
@HansRobo HansRobo merged commit c772887 into master Mar 4, 2025
26 checks passed
@github-actions github-actions bot deleted the RJD-1057/reorgnize-ostream-helper branch March 4, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants