Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the noises are not initialized in detection_sensor's noise_v2 #1541

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Mar 5, 2025

Description

This PR fix a bug in the PR that the perception noises are not initialized

Abstract

The perception noises are not initialized in the detection_sensor's noise_v2, which results in undefined noise values.

Background

None.

Details

Check the published pose in /localization/kinematic_state:

before:

header:
  stamp:
    sec: 1741165999
    nanosec: 608598102
  frame_id: map
objects:
- existence_probability: 0.0
  classification:
  - label: 3
    probability: 1.0
  kinematics:
    pose_with_covariance:
      pose:
        position:
          x: 1.6319554146606627e+130
          y: 2.8510855737315343e+131
          z: 101.25
        orientation:
          x: 0.0
          y: 0.0
          z: 0.5684897847198799
          w: -0.8226903212443578

after:

---
header:
  stamp:
    sec: 1741168200
    nanosec: 879934861
  frame_id: map
objects:
- existence_probability: 0.0
  classification:
  - label: 3
    probability: 1.0
  kinematics:
    pose_with_covariance:
      pose:
        position:
          x: 117.30633413377262
          y: 289.8219850335379
          z: 101.25
        orientation:
          x: 0.0
          y: 0.0
          z: 0.7342859116860377
          w: 0.6788403346144103

References

None.

Destructive Changes

None.

Known Limitations

None.

Copy link

github-actions bot commented Mar 5, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@xtk8532704 xtk8532704 requested a review from yamacir-kit March 5, 2025 10:00
@xtk8532704 xtk8532704 added the bug Something isn't working label Mar 5, 2025
@xtk8532704 xtk8532704 marked this pull request as ready for review March 5, 2025 10:01
@xtk8532704 xtk8532704 requested review from HansRobo and removed request for HansRobo March 5, 2025 10:11
Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants