Fix Vue plugin on Vue 2 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Vue plugin to work with Vue 2. Closes #737.
Not sure how the underlying changes slipped in, but they weren't supposed to.
app.config.globalProperties.routein Vue 3. This was discussed and removed in feat: Add Vue3 Provide/Inject Plugin #518, in Vue 3 it's the preferred way to register things globally.routeavailable everywhere. Removing this eventually was also discussed in feat: Add Vue3 Provide/Inject Plugin #518, but for Vue 2 users that would just be annoying.This PR makes one small change from the intended previous behavior—in Vue 3, we now register a global
routeproperty instead of adding a mixin.