Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format tests with on_days and/or before/after_time as budgets #426

Open
tijlleenders opened this issue Dec 15, 2023 · 0 comments
Open

Format tests with on_days and/or before/after_time as budgets #426

tijlleenders opened this issue Dec 15, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tijlleenders
Copy link
Owner

tijlleenders commented Dec 15, 2023

Is your feature request related to a problem? Please describe.
Anything that has an on_day filter and/or before/after_time is a budget - since that feature is not available for 'simple' goals.

Describe the solution you'd like

  • Go through all tests in tests/jsons/validated/ and tests/jsons/stable.bak and transform the input.json to a budget goal for any goal that has an on_day filter.
  • Also transform the input.json from a map of goals to a list of goals and use camelCase.
  • Update impossible tasks format to empty string or other expectation in new format

Describe alternatives you've considered
Allow on_day on 'simple' goals. This goes back on frontend UX decision to split budgets from goals for easier input interface. Budgets are done once - or at least infrequently. Goals can make use of a budget by being a sub-goal of a budget.

Additional context
An example of a input.json that needs to be transformed is tests/jsons/stable.bak/before-7/input.json

@tijlleenders tijlleenders added the enhancement New feature or request label Dec 15, 2023
@tijlleenders tijlleenders moved this to Parking lot in ZinZen scheduler Dec 15, 2023
@tijlleenders tijlleenders changed the title Format tests with on_days as budgets Format tests with on_days and/or after_time as budgets Dec 15, 2023
@tijlleenders tijlleenders changed the title Format tests with on_days and/or after_time as budgets Format tests with on_days and/or before/after_time as budgets Dec 15, 2023
@tijlleenders tijlleenders self-assigned this Jan 26, 2024
@thinkrapido thinkrapido moved this from Backlog to In Progress in ZinZen scheduler Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant