Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust fmt to the CI #448

Open
tijlleenders opened this issue Feb 17, 2024 · 2 comments
Open

Add Rust fmt to the CI #448

tijlleenders opened this issue Feb 17, 2024 · 2 comments

Comments

@tijlleenders
Copy link
Owner

Is your feature request related to a problem? Please describe.
I manually resolved a merge conflict in GH web UI and now the CI is failing because of Rust fmt.

Describe the solution you'd like
Rust fmt in CI - if there are any diffs - commit them as part of the PR without failing on fmt.

Describe alternatives you've considered
None.

Additional context
image

@tijlleenders tijlleenders moved this to temp to drag faster in ZinZen scheduler Feb 17, 2024
@thinkrapido
Copy link
Collaborator

This ticket is neither a feature request nor an issue.
It is a statement.
This ticketing system here is the wrong place for such things IMHO.
And what means the label devex?

@tijlleenders tijlleenders changed the title Rust fmt in the CI Add Rust fmt to the CI Feb 22, 2024
@tijlleenders
Copy link
Owner Author

@thinkrapido I changed the title.
What I'm asking for is that whenever you commit a PR, the code is automatically formatted. In Rust there is one standard - but if your local IDE is set differently or you don't format on save then the comittrd code might not be properly formatted.

A PR refused because I didn't apply Rust fmt - and it doesn't do so automayically - makes for a bad developer experience so that's why I applied the label 'developer experience' (devex).

@tijlleenders tijlleenders moved this from temp to drag faster to Backlog in ZinZen scheduler Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants