-
Notifications
You must be signed in to change notification settings - Fork 942
Skip function_telemetry.c when telemetry is disabled #7709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Good catch, thanks @hlinnaka |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7709 +/- ##
==========================================
+ Coverage 80.06% 81.93% +1.86%
==========================================
Files 190 246 +56
Lines 37181 45116 +7935
Branches 9450 11254 +1804
==========================================
+ Hits 29770 36965 +7195
- Misses 2997 3733 +736
- Partials 4414 4418 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This avoids allocating the telemetry hash table, which saves a little shared memory.
6ff88d2
to
17a2d9d
Compare
Hey @hlinnaka can you please sign the CLA (Contributor Lincense Agreement) in order to get this PR merged. |
Hi @hlinnaka, thanks for submitting this and would happy to include this PR, but would need you to sign the CLA in order to do so. Thanks for consideration! |
@hlinnaka I'm going to close the PR for now, given how long it's been open waiting for the CLA. But happy to re-open when you are ready. Thanks! |
This avoids allocating the telemetry hash table, which saves a little shared memory.
Disable-check: force-changelog-file
Disable-check: loader-change