Skip to content

Skip function_telemetry.c when telemetry is disabled #7709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hlinnaka
Copy link

@hlinnaka hlinnaka commented Feb 13, 2025

This avoids allocating the telemetry hash table, which saves a little shared memory.

Disable-check: force-changelog-file
Disable-check: loader-change

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fabriziomello
Copy link
Member

Good catch, thanks @hlinnaka

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (59f50f2) to head (17a2d9d).
Report is 1029 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7709      +/-   ##
==========================================
+ Coverage   80.06%   81.93%   +1.86%     
==========================================
  Files         190      246      +56     
  Lines       37181    45116    +7935     
  Branches     9450    11254    +1804     
==========================================
+ Hits        29770    36965    +7195     
- Misses       2997     3733     +736     
- Partials     4414     4418       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabriziomello fabriziomello added the loader Issue related to the loader label Feb 14, 2025
hlinnaka and others added 2 commits February 14, 2025 17:02
This avoids allocating the telemetry hash table, which saves a little
shared memory.
@fabriziomello
Copy link
Member

Hey @hlinnaka can you please sign the CLA (Contributor Lincense Agreement) in order to get this PR merged.

@mfreed
Copy link
Member

mfreed commented May 6, 2025

Hi @hlinnaka, thanks for submitting this and would happy to include this PR, but would need you to sign the CLA in order to do so. Thanks for consideration!

@mfreed mfreed self-requested a review May 24, 2025 01:31
@mfreed
Copy link
Member

mfreed commented May 24, 2025

@hlinnaka I'm going to close the PR for now, given how long it's been open waiting for the CLA. But happy to re-open when you are ready. Thanks!

@mfreed mfreed closed this May 24, 2025
@mfreed mfreed removed their request for review May 24, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Issue related to the loader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants