Skip to content

Update compression stats when merging chunks #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erimatnor
Copy link
Member

Merge compression chunk size stats when merging chunks. The merged chunk's stats is simply the sum of the stats of all compressed chunks that are merged. This ensures that the aggregate stats do not change due to the merge. Still, the stats might not accurately represent the merged chunk since merging both compressed and non-compressed chunks will leave some data uncompressed and this data won't be reflected in the stats of the merged chunk.

@erimatnor erimatnor force-pushed the update-compression-stats-on-merge-chunks branch 2 times, most recently from eb21756 to f33b3c9 Compare April 3, 2025 15:06
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 82.45614% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (e58bba9) to head (e072fcf).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/ts_catalog/compression_chunk_size.c 82.92% 2 Missing and 5 partials ⚠️
tsl/src/chunk.c 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7909      +/-   ##
==========================================
+ Coverage   82.10%   82.39%   +0.29%     
==========================================
  Files         253      254       +1     
  Lines       47278    47608     +330     
  Branches    11908    11994      +86     
==========================================
+ Hits        38816    39227     +411     
+ Misses       3698     3635      -63     
+ Partials     4764     4746      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@erimatnor erimatnor force-pushed the update-compression-stats-on-merge-chunks branch 2 times, most recently from 13a19e7 to 1c375af Compare April 8, 2025 12:28
@erimatnor erimatnor marked this pull request as ready for review April 8, 2025 14:44
Copy link
Member

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks fine. It's a little hard to follow and verify the stats, so you might want to have tests that actually save away the data before the merge and then do the computations in SQL to verify that they are what is expected after the merge.

Comment on lines +286 to +292
select * from _timescaledb_catalog.compression_chunk_size order by chunk_id;
chunk_id | compressed_chunk_id | uncompressed_heap_size | uncompressed_toast_size | uncompressed_index_size | compressed_heap_size | compressed_toast_size | compressed_index_size | numrows_pre_compression | numrows_post_compression | numrows_frozen_immediately
----------+---------------------+------------------------+-------------------------+-------------------------+----------------------+-----------------------+-----------------------+-------------------------+--------------------------+----------------------------
1 | 6 | 8192 | 0 | 32768 | 16384 | 8192 | 16384 | 1 | 1 | 1
3 | 7 | 8192 | 0 | 32768 | 16384 | 8192 | 16384 | 1 | 1 | 1
(2 rows)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use \x on for these.

@erimatnor erimatnor added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label May 7, 2025
Merge compression chunk size stats when merging chunks. The merged
chunk's stats is simply the sum of the stats of all compressed chunks
that are merged. This ensures that the aggregate stats do not change
due to the merge. Still, the stats might not accurately represent the
merged chunk since merging both compressed and non-compressed chunks
will leave some data uncompressed and this data won't be reflected in
the stats of the merged chunk.
@erimatnor erimatnor force-pushed the update-compression-stats-on-merge-chunks branch from 1c375af to e072fcf Compare May 7, 2025 11:53
@erimatnor erimatnor removed the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label May 7, 2025
@erimatnor erimatnor enabled auto-merge (rebase) May 7, 2025 11:54
@erimatnor erimatnor added this to the v2.20.0 milestone May 7, 2025
@erimatnor erimatnor merged commit f7d4f6c into timescale:main May 7, 2025
44 of 45 checks passed
@erimatnor erimatnor deleted the update-compression-stats-on-merge-chunks branch May 7, 2025 12:45
This was referenced May 7, 2025
philkra added a commit that referenced this pull request May 15, 2025
## 2.20.0 (2025-05-15)

This release contains performance improvements and bug fixes since the
2.19.3 release. We recommend that you upgrade at the next available
opportunity.

**Highlighted features in TimescaleDB v2.20.0**
* The columnstore now leverages *bloom filters* to deliver up to 6x
faster point queries on columns with high cardinality values, such as
UUIDs.
* Major *improvements to the columnstores' backfill process* enable
`UPSERTS` with strict constraints to execute up to 10x faster.
* *SkipScan is now supported in the columnstore*, including for DISTINCT
queries. This enhancement leads to dramatic query performance
improvements of 2000x to 2500x, especially for selective queries.
* SIMD vectorization for the bool data type is now enabled by default.
This change results in a 30–45% increase in performance for analytical
queries with bool clauses on the columnstore.
* *Continuous aggregates* now include experimental support for *window
functions and non-immutable functions*, extending the analytics use
cases they can solve.
* Several quality-of-life improvements have been introduced: job names
for continuous aggregates are now more descriptive, you can assign
custom names to them, and it is now possible to add unique constraints
along with `ADD COLUMN` operations in the columnstore.
* Improved management and optimization of chunks with the ability to
split large uncompressed chunks at a specified point in time using the
`split_chunk` function. This new function complements the existing
`merge_chunk` function that can be used to merge two small chunks into
one larger chunk.
* Enhancements to the default behavior of the columnstore now provide
better *automatic assessments* of `segment by` and `order by` columns,
reducing the need for manual configuration and simplifying initial
setup.

**PostgreSQL 14 support removal announcement**

Following the deprecation announcement for PostgreSQL 14 in TimescaleDB
v2.19.0, PostgreSQL 14 is no longer supported in TimescaleDB v2.20.0.
The currently supported PostgreSQL major versions are 15, 16, and 17.

**Features**
* [#7638](#7638) Bloom
filter sparse indexes for compressed columns. Can be disabled with the
GUC `timescaledb.enable_sparse_index_bloom`
* [#7756](#7756) Add
warning for poor compression ratio
* [#7762](#7762) Speed up
the queries that use minmax sparse indexes on compressed tables by
changing the index TOAST storage type to `MAIN`. This applies to newly
compressed chunks
* [#7785](#7785) Do
`DELETE` instead of `TRUNCATE` when locks aren't acquired
* [#7852](#7852) Allow
creating foreign key constraints on compressed tables
* [#7854](#7854) Remove
support for PG14
* [#7864](#7854) Allow
adding CHECK constraints to compressed chunks
* [#7868](#7868) Allow
adding columns with `CHECK` constraints to compressed chunks
* [#7874](#7874) Support
for SkipScan for distinct aggregates over the same column
* [#7877](#7877) Remove
blocker for unique constraints with `ADD COLUMN`
* [#7878](#7878) Don't
block non-immutable functions in continuous aggregates
* [#7880](#7880) Add
experimental support for window functions in continuous aggregates
* [#7899](#7899) Vectorized
decompression and filtering for boolean columns
* [#7915](#7915) New option
`refresh_newest_first` to continuous aggregate refresh policy API
* [#7917](#7917) Remove
`_timescaledb_functions.create_chunk_table` function
* [#7929](#7929) Add
`CREATE TABLE ... WITH` API for creating hypertables
* [#7946](#7946) Add
support for splitting a chunk
* [#7958](#7958) Allow
custom names for jobs
* [#7972](#7972) Add
vectorized filtering for constraint checking while backfilling into
compressed chunks
* [#7976](#7976) Include
continuous aggregate name in jobs informational view
* [#7977](#7977) Replace
references to compression with columnstore
* [#7981](#7981) Add
columnstore as alias for `enable_columnstore `in `ALTER TABLE`
* [#7983](#7983) Support
for SkipScan over compressed data
* [#7991](#7991) Improves
default `segmentby` options
* [#7992](#7992) Add API
into hypertable invalidation log
* [#8000](#8000) Add
primary dimension info to information schema
* [#8005](#8005) Support
`ALTER TABLE SET (timescaledb.chunk_time_interval='1 day')`
* [#8012](#8012) Add event
triggers support on chunk creation
* [#8014](#8014) Enable
bool compression by default by setting
`timescaledb.enable_bool_compression=true`. Note: for downgrading to
`2.18` or earlier version, use [this downgrade
script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.19.0-downgrade_new_compression_algorithms.sql)
* [#8018](#8018) Add
spin-lock during recompression on unique constraints
* [#8026](#8026) Allow
`WHERE` conditions that use nonvolatile functions to be pushed down to
the compressed scan level. For example, conditions like `time > now()`,
where `time` is a columnstore `orderby` column, will evaluate `now()`
and use the sparse index on `time` to filter out the entire compressed
batches that cannot contain matching rows.
* [#8027](#8027) Add
materialization invalidations API
* [#8047](#8027) Support
SkipScan for `SELECT DISTINCT` with multiple distincts when all but one
distinct is pinned
* [#8115](#8115) Add batch
size limiting during compression

**Bugfixes**
* [#7862](#7862) Release
cache pin when checking for `NOT NULL`
* [#7909](#7909) Update
compression stats when merging chunks
* [#7928](#7928) Don't
create a hypertable for implicitly published tables
* [#7982](#7982) Fix crash
in batch sort merge over eligible expressions
* [#8008](#8008) Fix
compression policy error message that shows number of successes
* [#8031](#8031) Fix
reporting of deleted tuples for direct batch delete
* [#8033](#8033) Skip
default `segmentby` if `orderby` is explicitly set
* [#8061](#8061) Ensure
settings for a compressed relation are found
* [#7515](#7515) Add
missing lock to Constraint-aware append
* [#8067](#8067) Make sure
hypercore TAM parent is vacuumed
* [#8074](#8074) Fix memory
leak in row compressor flush
* [#8099](#8099) Block
chunk merging on multi-dimensional hypertables
* [#8106](#8106) Fix
segfault when adding unique compression indexes to compressed chunks
* [#8127](#8127) Read
bit-packed version of booleans

**GUCs**
* `timescaledb.enable_sparse_index_bloom`: Enable creation of the bloom1
sparse index on compressed chunks; Default: `ON`
* `timescaledb.compress_truncate_behaviour`: Defines how truncate
behaves at the end of compression; Default: `truncate_only`
* `timescaledb.enable_compression_ratio_warnings`: Enable warnings for
poor compression ratio; Default: `ON`
* `timescaledb.enable_event_triggers`: Enable event triggers for chunks
creation; Default: `OFF`
* `timescaledb.enable_cagg_window_functions`: Enable window functions in
continuous aggregates; Default: `OFF`

**Thanks**
* @arajkumar for reporting that implicitly published tables were still
able to create hypertables
* @thotokraa for reporting an issue with unique expression indexes on
compressed chunks

---------

Signed-off-by: Philip Krauss <35487337+philkra@users.noreply.github.com>
Signed-off-by: Ramon Guiu <ramon@timescale.com>
Co-authored-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
Co-authored-by: Ramon Guiu <ramon@timescale.com>
@akuzm akuzm added the released-2.20.0 Released in 2.20.0 label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released-2.20.0 Released in 2.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants