Avoidable timeout on chat retrieval

[hippalectryon-0]

In cogs/logs.py

Archon/cogs/logs.py

Line 93 in d4abbec

inst.rcon.exec_command("a")

, cf lines in screenshot above:

If there has been no new messages since the last execution of _query (more precisely of inst.rcon.exec_command("a")), then self._sock.recv(HEADER_SIZE) in _recv_pkt (

Archon/rcon/connection.py

Line 166 in d4abbec

def _recv_pkt(self, skip_empty_headers=True):

) will hang and cause a timeout.

While this is not critical, it is avoidable (timeouts last ~10s, making the whole execution hang). All that is needed is to check if the socket has new content before executing _recv_pkt (or earlier) via:

import select

r, _, _ = select.select([self._sock], [], [], 0)
if len(r) == 0: return  # the socket doesn't have new content