Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Often chat messages are not caught by the RCON #6

Open
timraay opened this issue Dec 23, 2020 · 4 comments
Open

Often chat messages are not caught by the RCON #6

timraay opened this issue Dec 23, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@timraay
Copy link
Owner

timraay commented Dec 23, 2020

Possible caused by the end of multipacket response being attached with the chat message (and the chat message having the wrong packet type). This was observed on Squad version b-17.0.13.23847.

e.g. packet body: b'\x00\x00\x00\x01\x00\x00\x00[ChatAll] this is example chat\x00\x00'.

@timraay timraay added the bug Something isn't working label Dec 23, 2020
@hippalectryon-0
Copy link

Btw also a bug on the official valve RCON implementation. This can be fixed on the official valve RCON by disabling partial responses, but I think you use a custom implementation :(

@timraay
Copy link
Owner Author

timraay commented Dec 23, 2020

Can you elaborate on what you mean, perhaps with some links? Never heard of disabling partial responses.

@hippalectryon-0
Copy link

hippalectryon-0 commented Dec 23, 2020

On the python RCON API, in valve/rcon.py, in _consume, disable the part that handles partial responses:

image

Before doing that, valve's RCON library doesn't register Squad chat messages. Since making this fix, I've been catching them all.

@timraay
Copy link
Owner Author

timraay commented Dec 23, 2020

Note to self:

The longer the script is running the more apparent this issue becomes. After a restart it updates perfectly fine every 15s, whereas after several days it sometimes takes several minutes to fetch messages, or they may even be completely ignored. Likely this isn't an issue with the RCON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants