Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple values files #2

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Support multiple values files #2

merged 3 commits into from
Feb 4, 2025

Conversation

tiulpin
Copy link
Owner

@tiulpin tiulpin commented Feb 4, 2025

This pull request introduces support for handling multiple values files in the Helm chart validation tool. The main changes include the addition of a new ValueFiles type to manage multiple values files, updates to the command-line interface to accept multiple values files, and new tests to verify the merging of these files.

Changes to support multiple values files:

  • Added ValueFiles type to manage multiple values files, including methods String and Set to handle command-line input (cmd/main.go).
  • Updated the command-line interface to accept multiple values files using the -f flag and modified the usage message accordingly (cmd/main.go).
  • Replaced single values file handling with the new ValueFiles type in the main function (cmd/main.go) [1] [2].

Testing enhancements:

  • Added a new test TestMergeValues to verify that merging multiple values files produces the expected result, ensuring that values from subsequent files override those from earlier ones (cmd/main_test.go).

@tiulpin tiulpin merged commit 247751c into main Feb 4, 2025
2 checks passed
@tiulpin tiulpin deleted the tv/fixes branch February 4, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant