Skip to content

Commit 0d6a40b

Browse files
authored
Merge pull request #5 from tkaratug/laravel-10-support
Laravel 10 & php 8.2 support
2 parents 06c9875 + e4d7d5b commit 0d6a40b

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

.github/workflows/run-tests.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@ jobs:
1313
fail-fast: true
1414
matrix:
1515
os: [ubuntu-latest, windows-latest]
16-
php: [8.1]
17-
laravel: [9.*]
16+
php: [8.1, 8.2]
17+
laravel: [9.*, 10.*]
1818
stability: [prefer-lowest, prefer-stable]
1919
include:
2020
- laravel: 9.*
2121
testbench: 7.*
22+
- laravel: 10.*
23+
testbench: 8.*
2224

2325
name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}
2426

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
}
1717
],
1818
"require": {
19-
"php": "^8.1",
20-
"illuminate/contracts": "^9.0"
19+
"php": "^8.1 | ^8.2",
20+
"illuminate/contracts": "^9.0 | ^10.0"
2121
},
2222
"require-dev": {
2323
"laravel/pint": "^1.0",
24-
"orchestra/testbench": "^7.0",
24+
"orchestra/testbench": "^7.0 | ^8.0",
2525
"phpunit/phpunit": "^9.5"
2626
},
2727
"autoload": {

src/NotificationEventSubscriber.php

-9
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ class NotificationEventSubscriber
1212
{
1313
/**
1414
* Executes `onSent()` method in the notication.
15-
*
16-
* @param \Illuminate\Notifications\Events\NotificationSent $event
17-
* @return void
1815
*/
1916
public function handleNotificationSent(NotificationSent $event): void
2017
{
@@ -25,9 +22,6 @@ public function handleNotificationSent(NotificationSent $event): void
2522

2623
/**
2724
* Executes `onSending()` method in the notification.
28-
*
29-
* @param \Illuminate\Notifications\Events\NotificationSending $event
30-
* @return void
3125
*/
3226
public function handleNotificationSending(NotificationSending $event): void
3327
{
@@ -38,9 +32,6 @@ public function handleNotificationSending(NotificationSending $event): void
3832

3933
/**
4034
* The subscriber classes to register.
41-
*
42-
* @param \Illuminate\Events\Dispatcher $events
43-
* @return array
4435
*/
4536
public function subscribe(Dispatcher $events): array
4637
{

0 commit comments

Comments
 (0)