0083 patch -> put 변경, 이미지 png 선택 가능, grass 구간 수정 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
soyekwon
commented
Feb 22, 2022
•
soyekwon
commented
- patch -> put 변경
- 이미지 png 선택 가능
- grass 구간 today 기준으로 수정
|
✔️ Deploy Preview for todaytheylearned ready! 🔨 Explore the source changes: a319a64 🔍 Inspect the deploy log: https://app.netlify.com/sites/todaytheylearned/deploys/62151a088f01e70007a2d0b8 😎 Browse the preview: https://deploy-preview-90--todaytheylearned.netlify.app/ |
soyekwon
requested review from
shinkeonkim,
minjj0905 and
cychann
and removed request for
minjj0905 and
shinkeonkim
cychann
reviewed
Feb 22, 2022
| @@ -49,7 +49,6 @@ const ProfileEdit = () => { | |||
| const handleSubmit = useCallback(() => { | |||
| formData.append('username', info.username); | |||
| formData.append('tags', JSON.stringify(taglist)); | |||
There was a problem hiding this comment.
아래 67번째 tagSubmit 함수에서 formData에 tags append하는 코드 없어도 되지 않나욤??
그리고 tagSubmit 함수에서 빈 문자열 들어갔을 땐 태그 추가 안되도록 막아줘야 할 것 같아요
soyekwon
changed the title
Closed
minjj0905
reviewed
Feb 22, 2022
| @@ -1,16 +1,35 @@ | |||
| import React, { useState } from 'react'; | |||
| import { useSelector } from 'react-redux'; | |||
| /* eslint-disable no-unused-vars */ | |||
| newDate.setDate(newDate.getDate() + numDays); | ||
| return newDate; | ||
| }; | ||
|
|
There was a problem hiding this comment.
p3: moment라는 javascript 날짜/시간 관련 라이브러리가 있습니당
그거로 하면 굳이 함수 만들지 않고도 날짜를 쉽게 뺄 수 있습니다
minjj0905
reviewed
Feb 22, 2022
src/pages/Article/Article.jsx
Outdated
| <strong style={{ marginRight: '0.5rem' }}>{singleArticle?.user.username}</strong> | ||
| <button type="button" style={{ marginRight: '0.5rem' }}> | ||
| {singleArticle?.user.username} | ||
| </button> |
There was a problem hiding this comment.
p1: 여기 스타일이 깨져있어요 ㅠㅠ 원래대로 돌려주십쇼.......... 그냥 버튼 연결은 유저페이지 머지되면 달테니 아예 원복 plz
|
merge... |
This was
linked to
issues
Feb 22, 2022
Closed
Open
Closed
Closed
|
@soyekwon 앞으로는 리뷰 수정 후 다시 review를 요청하도록 하십시오... |
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.