-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: made adding a new loader easier #155
Conversation
referencing my comment in #133 turned out to be a very small change.
|
This is a very cool PR. I like the simplicity of it + the clarity it adds. Would make it a lot easier to support more file extensions. |
@toddbluhm awesome-sauce, I believe the tests only failed because i didn't pre-lint, so thats easily fixable. Now it's been a while since i wrote this and I'm still dealing with the aftermath of a corrupted system-drive on my main machine, so rewisiting the code won't be ultra swift, but i'll take your response as a green-light on polishing this up. Want me to include YAML and/or JSON5 suport rightaway aswell? I'd suggest to include both, but it's your call. |
Any update on this? I'm happy to help get this merged if required. We would really like to use json with comments. @toddbluhm if you're concerned about adding another dependency you could make it a peerDependency and/or just have a helpful error message if the user tries to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! I've rebased it to resolve conflicts, since there's been a lot of refactoring lately
Co-authored-by: KilianKilmister <KilianKilmister@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for getting this updated.
Also just to make sure, @k-yle you can still merge these branches without PR approval correct? I want to make sure you can in case I am ever MIA for a bit again (I don't plan to be, but you never know). Also, I will get you NPM access soon.
awesome, thanks @toddbluhm - Currently, I can merge other peoples' PRs, but not my own PRs. This seems reasonable; assuming there are always 2 active maintainers |
No description provided.