Skip to content

chore: add TransformOptions type to init in integration tests #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adamstankiewicz
Copy link
Contributor

While exploring some of the transforms and their associated tests, I noticed the init function used to initialize style-dictionary (i.e., register sd-transforms and dict.buildAllPlatforms()) accepts an untyped function argument transformOpts.

This PR associates the TransformOptions type to this transformOpts argument.

In doing so, TypeScript began throwing an error within cross-file-refs.test.ts that the existing expand option passed to init isn't valid per the TransformOptions type. The tests pass regardless of whether expand is present or not in the provided options, which seems to indicate nothing consumes the property value. As such, I've removed expand from this test suite.

Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: 3220935

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adamstankiewicz
Copy link
Contributor Author

[inform] The changes in this PR are also included in a related proposed change: #313

If that one merges, this one may be closed. Otherwise, this can be its own standalone contribution, too :)

@jorenbroekema
Copy link
Member

Thanks :)!

@jorenbroekema jorenbroekema merged commit 6e342f4 into tokens-studio:main Sep 5, 2024
2 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/adds-transformoptions-type-integratio-init branch September 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants