Fix/align color precision to colorjs default #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd default color precision
…gain (cherry picked from commit 1c151ee)
(cherry picked from commit 76dbfba) # Conflicts: # test/integration/color-modifier-references.test.ts # test/spec/color-modifiers/transformColorModifiers.spec.ts
(cherry picked from commit 0e7ce70)
(cherry picked from commit 72bca07) # Conflicts: # test/integration/color-modifier-references.test.ts
🦋 Changeset detectedLatest commit: def63c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 10, 2025
|
Adding changeset after your review @jorenbroekema |
…fier value calculations
jorenbroekema
approved these changes
Apr 11, 2025
DarioSoller
force-pushed
the
fix/align-color-precision-to-colorjs-default
branch
from
198b97e to
def63c2
Compare
|
Awesome, thanks again for taking lead on this! |
This was referenced May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the chain of consequences of the ColorJS precision change idea, we now should just stick with the ColorJS default precision. That way the misconception on how precision in ColorJS works should be fixed to a precision value, that was actually assumed to be used in sd-transforms.
Related Links:
Therefore this PR brings the following changes: