feat: add optional color modify mathFractionDigits and color precision properties #49
Conversation
|
| mathFractionDigits?: number; | ||
| precision?: number; |
There was a problem hiding this comment.
| mathFractionDigits?: number; | |
| precision?: number; | |
| decimals?: number; |
I think I want to think a bit further ahead and make these a bit more brief in naming.
We'll map it to the appropriate values in sd-transforms if needed, but I think decimals / precision are the best names for these.
In the end, it comes down to that decimals gets passed to here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed#digits
They refer to it as "digits" but I think this is a poor name as well, it's specifically the digits after the decimal point so I think "decimals" is the best name.
I think I'm going to plan to break this in sd-transforms next major to also use decimals but for now we'll map it to mathFractionDigits there.
As for precision, I feel like we should have a single property. They both define the amount of digits after decimal point for number values. Having a different amount for math expressions in color definitions vs the output color numbers after conversion doesn't make much sense to me, I think they would always be the same.
There was a problem hiding this comment.
Just be aware that mathFractionDigits currently define how precise the calculations are done, and precision right now sets how many decimals the color values have in the output files. I am open for renaming, but I fear your suggestion still leaves room for confusion!?
How about renaming:
mathFractionDigits-->calcPrecisionprecision-->colorDecimals
There was a problem hiding this comment.
Let's discuss this one on Slack maybe, I wanna see if we can actually bring this to a single property by making some (imo sensible) assumptions.
There was a problem hiding this comment.
The tricky part is that for ColorJS.io precision 3 means a number like 89,4%, so ColorJS.io precision 3 turns out to be a color like rgb(44.3% 59.5% 89.9%). So if you reuse decimals on the ColorJS.io precision, this is misleading, because for a color like rgb(44.325% 59.545% 89.992%) you would need a color precision of 5.
I mean we could maybe just always add 2 to the decimal setting!?
There was a problem hiding this comment.
For example, let's assume I have a mix color calculation, that with precision 4 is #c2c5d0, for precision 2 this will be #c2c4cf and for precision 1 this will be #ccc and for precision 0 this even is #fff, that's how this works in ColorJS.io.
So this makes quite a big difference for colors, maybe having bigger impact, than for other spacing calculations?
|
can you add a changeset as well ( |
I will do, when we have a final decision for the property names. |
|
Closed in favor of tokens-studio/sd-transforms#354 |
Needed to support PR: tokens-studio/sd-transforms#351