Skip to content

Commit

Permalink
Merge pull request #42 from tompave/version_updates
Browse files Browse the repository at this point in the history
Maintenance version updates
  • Loading branch information
tompave authored Aug 9, 2024
2 parents 30120c9 + ea064cd commit a8569c9
Show file tree
Hide file tree
Showing 6 changed files with 56 additions and 52 deletions.
27 changes: 12 additions & 15 deletions .credo.exs
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,12 @@
#
# {Credo.Check.Design.AliasUsage,
# [priority: :low, if_nested_deeper_than: 2, if_called_more_often_than: 0]},

{Credo.Check.Design.TagFIXME, []},
# You can also customize the exit_status of each check.
# If you don't want TODO comments to cause `mix credo` to fail, just
# set this value to 0 (zero).
#
{Credo.Check.Design.TagTODO, [exit_status: 2]},
{Credo.Check.Design.TagFIXME, []},

#
## Readability Checks
Expand Down Expand Up @@ -123,19 +122,19 @@
{Credo.Check.Refactor.Apply, []},
{Credo.Check.Refactor.CondStatements, []},
{Credo.Check.Refactor.CyclomaticComplexity, []},
{Credo.Check.Refactor.FilterCount, []},
{Credo.Check.Refactor.FilterFilter, []},
{Credo.Check.Refactor.FunctionArity, []},
{Credo.Check.Refactor.LongQuoteBlocks, []},
{Credo.Check.Refactor.MatchInCondition, []},
{Credo.Check.Refactor.MapJoin, []},
{Credo.Check.Refactor.MatchInCondition, []},
{Credo.Check.Refactor.NegatedConditionsInUnless, []},
{Credo.Check.Refactor.NegatedConditionsWithElse, []},
{Credo.Check.Refactor.Nesting, [max_nesting: 3]},
{Credo.Check.Refactor.RedundantWithClauseResult, []},
{Credo.Check.Refactor.RejectReject, []},
{Credo.Check.Refactor.UnlessWithElse, []},
{Credo.Check.Refactor.WithClauses, []},
{Credo.Check.Refactor.FilterCount, []},
{Credo.Check.Refactor.FilterFilter, []},
{Credo.Check.Refactor.RejectReject, []},
{Credo.Check.Refactor.RedundantWithClauseResult, []},

#
## Warnings
Expand All @@ -151,7 +150,7 @@
{Credo.Check.Warning.OperationWithConstantResult, []},
{Credo.Check.Warning.RaiseInsideRescue, []},
{Credo.Check.Warning.SpecWithStruct, []},
{Credo.Check.Warning.WrongTestFileExtension, []},
{Credo.Check.Warning.UnsafeExec, []},
{Credo.Check.Warning.UnusedEnumOperation, []},
{Credo.Check.Warning.UnusedFileOperation, []},
{Credo.Check.Warning.UnusedKeywordOperation, []},
Expand All @@ -160,11 +159,12 @@
{Credo.Check.Warning.UnusedRegexOperation, []},
{Credo.Check.Warning.UnusedStringOperation, []},
{Credo.Check.Warning.UnusedTupleOperation, []},
{Credo.Check.Warning.UnsafeExec, []}
{Credo.Check.Warning.WrongTestFileExtension, []}
],
disabled: [
#
# Checks scheduled for next check update (opt-in for now, just replace `false` with `[]`)
# Checks scheduled for next check update (opt-in for now)
{Credo.Check.Refactor.UtcNowTruncate, []},

#
# Controversial and experimental checks (opt-in, just move the check to `:enabled`
Expand All @@ -180,13 +180,13 @@
{Credo.Check.Readability.MultiAlias, []},
{Credo.Check.Readability.NestedFunctionCalls, []},
{Credo.Check.Readability.OneArityFunctionInPipe, []},
{Credo.Check.Readability.OnePipePerLine, []},
{Credo.Check.Readability.SeparateAliasRequire, []},
{Credo.Check.Readability.SingleFunctionToBlockPipe, []},
{Credo.Check.Readability.SinglePipe, []},
{Credo.Check.Readability.Specs, []},
{Credo.Check.Readability.StrictModuleLayout, []},
{Credo.Check.Readability.WithCustomTaggedTuple, []},
{Credo.Check.Readability.OnePipePerLine, []},
{Credo.Check.Refactor.ABCSize, []},
{Credo.Check.Refactor.AppendSingleItem, []},
{Credo.Check.Refactor.DoubleBooleanNegation, []},
Expand All @@ -203,13 +203,10 @@
{Credo.Check.Warning.LeakyEnvironment, []},
{Credo.Check.Warning.MapGetUnsafePass, []},
{Credo.Check.Warning.MixEnv, []},
{Credo.Check.Warning.UnsafeToAtom, []},
{Credo.Check.Warning.UnsafeToAtom, []}

# {Credo.Check.Refactor.MapInto, []},

{Credo.Check.Design.AliasUsage, []},
{Credo.Check.Readability.PreferImplicitTry, []},

#
# Custom checks can be created using `mix credo.gen.check`.
#
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:
branches: [master]

env:
elixir_version: '1.15'
otp_version: '26.0'
elixir_version: '1.17'
otp_version: '27.0'

jobs:
credo:
Expand All @@ -20,16 +20,16 @@ jobs:

steps:
- name: Set up Elixir and OTP
uses: erlef/setup-elixir@v1
uses: erlef/setup-beam@v1
with:
elixir-version: ${{ env.elixir_version }}
otp-version: ${{ env.otp_version }}

- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: 'Restore cache for deps/ and _build/ directories'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
deps
Expand Down
24 changes: 13 additions & 11 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,21 @@ jobs:
fail-fast: false
matrix:
elixir:
- '1.17'
- '1.16'
- '1.15'
- '1.14'
- '1.13'
otp:
- '26.1'
- '26.0'
- '27.0'
- '26.2'
- '25.3'
- '24.3'
exclude:
- elixir: '1.13'
otp: '26.1'
- elixir: '1.13'
otp: '26.0'
- elixir: '1.17'
otp: '24.3'
- elixir: '1.16'
otp: '27.0'
- elixir: '1.15'
otp: '27.0'

services:
redis:
Expand All @@ -37,16 +39,16 @@ jobs:
steps:

- name: Set up Elixir and OTP
uses: erlef/setup-elixir@v1
uses: erlef/setup-beam@v1
with:
elixir-version: ${{ matrix.elixir }}
otp-version: ${{ matrix.otp }}

- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: 'Restore cache for deps/ and _build/ directories'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
deps
Expand Down
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
# Changelog

## v1.1.0 (unreleased)

* Add support for Elixir 1.16 and 1.17. Drop support for Elixir 1.13 and 1.14. Elixir >= 1.15 is now required. Dropping support for older versions of Elixir simply means that this package is no longer tested with them in CI, and that compatibility issues are not considered bugs.
* Require `fun_with_flags ~> 1.12`. This is not strictly required because `v1.11` will also work, but it makes it easier to ensure that both libraries are compatible with the latest Elixir and OTP.

## v1.0.0

No changes, but this package has been stable for so long that it's time to graduate to `v1`. It's possible to just upgrade from `v0.x` to `v1.0` without issues. This also makes it easier to keep the versions of this UI package and of the `fun_with_flags` package in lockstep, when `v2` is released.

## v0.9.0

* Add support for Elixir 1.14, 1.15. Drop support for Elixir 1.11 and 1.12. Elixir >= 1.13 is now required. Dropping support for older versions of Elixir simply means that this package is no longer tested with them in CI, and that compatibility issues are not considered bugs.
* Add support for Elixir 1.14 and 1.15. Drop support for Elixir 1.11 and 1.12. Elixir >= 1.13 is now required. Dropping support for older versions of Elixir simply means that this package is no longer tested with them in CI, and that compatibility issues are not considered bugs.
* Drop support for Erlang/OTP 22 and 23, and Erlang/OTP >= 24 is now required. Dropping support for older versions of Erlang/OTP simply means that this package is not tested with them in CI, and that compatibility issues are not considered bugs.
* Addressed Plug an Logger deprecation warnings. Thank you [Ch4s3](https://github.com/Ch4s3) ([pull/27](https://github.com/tompave/fun_with_flags_ui/pull/27)) and [ryvasquez](https://github.com/ryvasquez) ([pull/31](https://github.com/tompave/fun_with_flags_ui/pull/31)) for bringing it up and addressing them.
* Addressed XSS vulnerability. (Thanks [ryanwinchester](https://github.com/ryanwinchester), [pull/29](https://github.com/tompave/fun_with_flags_ui/pull/29), plus [pull/34](https://github.com/tompave/fun_with_flags_ui/pull/34))
Expand Down
4 changes: 2 additions & 2 deletions mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ defmodule FunWithFlagsUi.Mixfile do
app: :fun_with_flags_ui,
source_url: "https://github.com/tompave/fun_with_flags_ui",
version: @version,
elixir: "~> 1.13",
elixir: "~> 1.15",
elixirc_paths: elixirc_paths(Mix.env),
build_embedded: Mix.env == :prod,
start_permanent: Mix.env == :prod,
Expand Down Expand Up @@ -44,7 +44,7 @@ defmodule FunWithFlagsUi.Mixfile do
{:plug, "~> 1.12"},
{:plug_cowboy, ">= 2.0.0", optional: true},
{:cowboy, ">= 2.0.0", optional: true},
{:fun_with_flags, "~> 1.11"},
{:fun_with_flags, "~> 1.12"},
{:redix, "~> 1.0", only: [:dev, :test]},
{:ex_doc, ">= 0.0.0", only: :dev},
{:credo, "~> 1.7", only: :dev, runtime: false},
Expand Down
Loading

0 comments on commit a8569c9

Please sign in to comment.