Skip to content

Commit 1d3ef2a

Browse files
committed
downloader bug fixes
- Dependency fixes. - kotlin update. - Fixed okResponse method in httpUrlConnectionDownloader class.
1 parent 556f143 commit 1d3ef2a

File tree

8 files changed

+25
-18
lines changed

8 files changed

+25
-18
lines changed

CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
Version 2.0.0-RC6
2+
- Dependency fixes.
3+
- kotlin update.
4+
- Fixed okResponse method in httpUrlConnectionDownloader class.
5+
16
Version 2.0.0-RC5
27
- Behavior Change: Added download speed reporting in Fetch Listener onProgress method.
38
- Fixed ETA reporting. Reports are more accurate using weighted moving average.

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[![Build Status](https://travis-ci.org/tonyofrancis/Fetch.svg?branch=v2)](https://travis-ci.org/tonyofrancis/Fetch)
2-
[ ![Download](https://api.bintray.com/packages/tonyofrancis/maven/fetch2/images/download.svg?version=2.0.0-RC5) ](https://bintray.com/tonyofrancis/maven/fetch2/2.0.0-RC5/link)
2+
[ ![Download](https://api.bintray.com/packages/tonyofrancis/maven/fetch2/images/download.svg?version=2.0.0-RC6) ](https://bintray.com/tonyofrancis/maven/fetch2/2.0.0-RC6/link)
33
[![Android Arsenal](https://img.shields.io/badge/Android%20Arsenal-Android%20Networking-blue.svg?style=flat)](https://android-arsenal.com/details/1/5196)
44
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/tonyofrancis/Fetch/blob/master/LICENSE)
55

@@ -44,7 +44,7 @@ How to use Fetch
4444
Using Fetch is easy! Just add the Gradle dependency to your application's build.gradle file.
4545

4646
```java
47-
implementation "com.tonyodev.fetch2:fetch2:2.0.0-RC5"
47+
implementation "com.tonyodev.fetch2:fetch2:2.0.0-RC6"
4848
```
4949

5050
Next, get an instance of Fetch using the builder, and request a download.
@@ -239,7 +239,7 @@ to use the OkHttp Downloader instead. You can create your own custom downloaders
239239
if necessary. See the Java docs for details.
240240
241241
```java
242-
implementation "com.tonyodev.fetch2downloaders:fetch2downloaders:2.0.0-RC5"
242+
implementation "com.tonyodev.fetch2downloaders:fetch2downloaders:2.0.0-RC6"
243243
```
244244
Set the OkHttp Downloader for Fetch to use.
245245
```java
@@ -260,7 +260,7 @@ If you would like to take advantage of RxJava2 features when using Fetch,
260260
add the following gradle dependency to your application's build.gradle file.
261261

262262
```java
263-
implementation "com.tonyodev.fetch2rx:fetch2rx:2.0.0-RC5"
263+
implementation "com.tonyodev.fetch2rx:fetch2rx:2.0.0-RC6"
264264
```
265265

266266
RxFetch makes it super easy to enqueue download requests and query downloads using rxJava2 functional methods.
@@ -292,7 +292,7 @@ Fetch1 Migration
292292

293293
Migrate downloads from Fetch1 to Fetch2 using the migration assistant. Add the following gradle dependency to your application's build.gradle file.
294294
```java
295-
implementation "com.tonyodev.fetchmigrator:fetchmigrator:2.0.0-RC5"
295+
implementation "com.tonyodev.fetchmigrator:fetchmigrator:2.0.0-RC6"
296296
```
297297
298298
Then run the Migrator.

fetch2/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ android {
2626
defaultConfig {
2727
minSdkVersion library_min_version
2828
targetSdkVersion library_target_version
29-
versionCode 6
30-
versionName "2.0.0-RC5"
29+
versionCode library_version_code
30+
versionName library_version
3131

3232
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3333

@@ -75,7 +75,7 @@ publish {
7575
userOrg = 'tonyofrancis'
7676
groupId = 'com.tonyodev.fetch2'
7777
artifactId = 'fetch2'
78-
publishVersion = '2.0.0-RC5'
78+
publishVersion = library_version
7979
desc = 'Fetch is a simple, powerful, customizable file download manager library for Android.'
8080
website = 'https://github.com/tonyofrancis/fetch'
8181
}

fetch2/src/main/java/com/tonyodev/fetch2/fetch/FetchModulesBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ object FetchModulesBuilder {
6969
logger = prefs.logger)
7070

7171
downloadManager = DownloadManagerImpl(
72-
downloader = defaultDownloader,
72+
downloader = prefs.downloader,
7373
concurrentLimit = prefs.concurrentLimit,
7474
progressReportingIntervalMillis = prefs.progressReportingIntervalMillis,
7575
downloadBufferSizeBytes = prefs.downloadBufferSizeBytes,

fetch2downloaders/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ android {
2424
defaultConfig {
2525
minSdkVersion library_min_version
2626
targetSdkVersion library_target_version
27-
versionCode 6
28-
versionName "2.0.0-RC5"
27+
versionCode library_version_code
28+
versionName library_version
2929

3030
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3131

@@ -75,7 +75,7 @@ publish {
7575
userOrg = 'tonyofrancis'
7676
groupId = 'com.tonyodev.fetch2downloaders'
7777
artifactId = 'fetch2downloaders'
78-
publishVersion = '2.0.0-RC5'
78+
publishVersion = library_version
7979
desc = 'Downloaders for Fetch2'
8080
website = 'https://github.com/tonyofrancis/fetch'
8181
}

fetch2rx/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ android {
2323
defaultConfig {
2424
minSdkVersion library_min_version
2525
targetSdkVersion library_target_version
26-
versionCode 6
27-
versionName "2.0.0-RC5"
26+
versionCode library_version_code
27+
versionName library_version
2828

2929
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3030

@@ -71,7 +71,7 @@ publish {
7171
userOrg = 'tonyofrancis'
7272
groupId = 'com.tonyodev.fetch2rx'
7373
artifactId = 'fetch2rx'
74-
publishVersion = '2.0.0-RC5'
74+
publishVersion = library_version
7575
desc = 'RxJava extensions for Fetch2'
7676
website = 'https://github.com/tonyofrancis/fetch'
7777
}

fetchmigrator/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ android {
2323
defaultConfig {
2424
minSdkVersion library_min_version
2525
targetSdkVersion library_target_version
26-
versionCode 6
27-
versionName "2.0.0-RC5"
26+
versionCode library_version_code
27+
versionName library_version
2828

2929
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3030

@@ -70,7 +70,7 @@ publish {
7070
userOrg = 'tonyofrancis'
7171
groupId = 'com.tonyodev.fetchmigrator'
7272
artifactId = 'fetchmigrator'
73-
publishVersion = '2.0.0-RC5'
73+
publishVersion = library_version
7474
desc = 'Migration Assistant for Fetch'
7575
website = 'https://github.com/tonyofrancis/fetch'
7676
}

versions.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,6 @@ ext {
1616
rxAndroid2_version = "2.0.1"
1717
timber_version = "4.6.0"
1818
novoda_bintray_version = "0.8.0"
19+
library_version = "2.0.0-RC6"
20+
library_version_code = 7
1921
}

0 commit comments

Comments
 (0)