-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve version handling and build process #482
Conversation
tphakala
commented
Feb 21, 2025
- Update Dockerfile to use BUILD_VERSION instead of VERSION
- Modify main.go to display version without 'v' prefix
- Update Taskfile.yml to support custom version via BUILD_VERSION
- Enhance GitHub workflows for nightly and release builds to use consistent version detection
- Improve version tagging and manifest creation in CI/CD pipelines
- Update Dockerfile to use BUILD_VERSION instead of VERSION - Modify main.go to display version without 'v' prefix - Update Taskfile.yml to support custom version via BUILD_VERSION - Enhance GitHub workflows for nightly and release builds to use consistent version detection - Improve version tagging and manifest creation in CI/CD pipelines
Caution Review failedThe pull request is closed. WalkthroughThe changes update the CI/CD workflows, Dockerfile, Taskfile, and main.go to use dynamic versioning based on Git tags. New steps in the workflows retrieve the version via a Git command and propagate this value as an environment variable, replacing hardcoded strings in Docker build arguments and manifest creation. The Dockerfile and Taskfile now use a BUILD_VERSION variable, and the version output in main.go is simplified. This overall modification enhances traceability and consistency in build and release processes. Changes
Sequence Diagram(s)sequenceDiagram
participant W as Workflow Engine
participant G as GetVersion Step
participant D as Docker Build
participant M as Manifest Creation
W->>G: Run "Get version" (git describe)
G-->>W: Return version value
W->>D: Trigger Docker Build using BUILD_VERSION
W->>M: Execute manifest creation with BUILD_VERSION
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|