You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should be relatively simple, but one thing to note is that SPIR-V relies on setting some features that aren't set by wgpu (like the Vulkan memory model), so the device still needs to be created on the cubecl side if you want to support SPIR-V. Or if both things need custom features I suppose you could copy paste what we do in SPIR-V and add whatever you need. Either way the device needs custom creation logic, a default wgpu device from another library wouldn't work.
I think we should document that somewhere for the existing device variant, maybe even check for the required features and error if they're not present (so you don't get an ugly segfault later).
The wgpu device sharing example shows a possible way to integrate a wgpu device with other programs.
However if
R::client(&shared_device)
is called there is a panic:(from
crates/cubecl-wgpu/src/runtime.rs
request_adapter)As such there isn't a nice way (or any way?) to get a compute client.
Locally I modified
crates/cubecl-wgpu/src/runtime.rs
ininit_device
to return the compute client it creates, but a proper fix would be nice.The text was updated successfully, but these errors were encountered: