Skip to content

Commit bef9f8e

Browse files
author
DangHieu1407
committed
Code Runner: The full-screen and exit buttons lack keyboard tab support #773786
1 parent 7e9b816 commit bef9f8e

5 files changed

+22
-14
lines changed

amd/build/userinterfacewrapper.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

amd/build/userinterfacewrapper.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

amd/src/userinterfacewrapper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ define(['jquery', 'core/templates', 'core/notification'], function($, Templates,
145145
function InterfaceWrapper(uiname, textareaId) {
146146
let t = this; // For use by embedded functions.
147147

148-
this.GUTTER = 14; // Size of gutter at base of wrapper Node (pixels)
148+
this.GUTTER = 16; // Size of gutter at base of wrapper Node (pixels)
149149
this.DEFAULT_SYNC_INTERVAL_SECS = 5;
150150

151151
const PIXELS_PER_ROW = 19; // For estimating height of textareas.

styles.css

+17-9
Original file line numberDiff line numberDiff line change
@@ -260,16 +260,12 @@ div.coderunner-test-results.partial {
260260
/* Fullscreen and exit fullscreen */
261261
.que.coderunner .button-exit-fullscreen,
262262
body#page-question-type-coderunner .button-exit-fullscreen {
263-
bottom: -5px;
263+
bottom: 0;
264264
}
265265

266266
.que.coderunner .button-fullscreen,
267267
body#page-question-type-coderunner .button-fullscreen {
268-
bottom: -6px;
269-
}
270-
271-
body#page-question-type-coderunner .col-md-9 .button-fullscreen {
272-
margin-right: 15px;
268+
bottom: -1px;
273269
}
274270

275271
.que.coderunner .button-fullscreen,
@@ -278,11 +274,23 @@ body#page-question-type-coderunner .button-fullscreen,
278274
body#page-question-type-coderunner .button-exit-fullscreen {
279275
border: none;
280276
background: transparent;
281-
margin-right: 4px;
282-
right: 12px;
277+
margin: 0 0 2px 0;
278+
height: 15px;
279+
width: 20px;
280+
padding: 0;
281+
right: 15px;
283282
z-index: 10;
284283
}
285284

285+
.que.coderunner .button-fullscreen:focus,
286+
.que.coderunner .button-exit-fullscreen:focus,
287+
body#page-question-type-coderunner .button-fullscreen:focus,
288+
body#page-question-type-coderunner .button-exit-fullscreen:focus {
289+
display: flex;
290+
justify-content: center;
291+
outline: 2px solid black;
292+
}
293+
286294
.que.coderunner .button-fullscreen img.icon:hover,
287295
.que.coderunner .button-exit-fullscreen img.icon:hover,
288296
body#page-question-type-coderunner .button-fullscreen img.icon:hover,
@@ -302,7 +310,7 @@ body#page-question-type-coderunner .button-exit-fullscreen img.icon:hover {
302310
body#page-question-type-coderunner .button-exit-fullscreen img.icon,
303311
body#page-question-type-coderunner .button-fullscreen img.icon {
304312
margin-right: unset;
305-
margin-bottom: 2px;
313+
margin-bottom: 10px;
306314
width: 15px;
307315
height: 15px;
308316
}

templates/screenmode_button.mustache

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
2525
}
2626
}}
27-
<div class='screen-mode-button'>
28-
<button class="button-fullscreen position-absolute d-none" tabindex="-1" name="fullscreen">
27+
<div class="screen-mode-button">
28+
<button class="button-fullscreen position-absolute d-none" name="fullscreen">
2929
{{#pix}}fullscreen, qtype_coderunner, {{#str}}fullscreen, qtype_coderunner{{/str}}{{/pix}}
3030
</button>
3131
<button class="button-exit-fullscreen position-absolute d-none" name="windowed">

0 commit comments

Comments
 (0)