Delete stray dead code

trampgeek · trampgeek · commit cd7ebe52ef05 · 2025-01-25T17:10:52.000+13:00
diff --git a/db/upgradelib.php b/db/upgradelib.php
@@ -195,9 +195,7 @@ function moodle5_top_category() {
             mtrace('CodeRunner: creating new system question bank');
             $newmod = question_bank_helper::create_default_open_instance($course, $bankname, question_bank_helper::TYPE_SYSTEM);
         }
-        $CFG->upgraderunning = $savedupgradestatus;
     } catch (Exception $e) {
-        $CFG->upgraderunning = $savedupgradestatus;
         throw new coding_exception('Upgrade failed: error creating system question bank');
     }
     $newtopcategory = question_get_top_category($newmod->context->id, true);

Original file line number	Diff line number	Diff line change
`@@ -195,9 +195,7 @@ function moodle5_top_category() {`
`195`	`195`	`mtrace('CodeRunner: creating new system question bank');`
`196`	`196`	`$newmod = question_bank_helper::create_default_open_instance($course, $bankname, question_bank_helper::TYPE_SYSTEM);`
`197`	`197`	`}`
`198`		`- $CFG->upgraderunning = $savedupgradestatus;`
`199`	`198`	`} catch (Exception $e) {`
`200`		`- $CFG->upgraderunning = $savedupgradestatus;`
`201`	`199`	`throw new coding_exception('Upgrade failed: error creating system question bank');`
`202`	`200`	`}`
`203`	`201`	`$newtopcategory = question_get_top_category($newmod->context->id, true);`