Updates to get bultestall script working with enhanced bulk_tester class.

Author: mckeownp

bulktestall.php

@@ -45,8 +45,7 @@
 $title = get_string('bulktesttitle', 'qtype_coderunner', $context->get_context_name());
 $PAGE->set_title($title);
 
-// Create the helper class.
-$bulktester = new qtype_coderunner_bulk_tester($context);
+
 $numpasses = 0;
 $allfailingtests = [];
 $allmissinganswers = [];
@@ -60,14 +59,16 @@
 echo $OUTPUT->heading($title, 1);
 
 // Run the tests.
-foreach ($bulktester->get_num_coderunner_questions_by_context() as $contextid => $numcoderunnerquestions) {
+$contextdata = qtype_coderunner_bulk_tester::get_num_coderunner_questions_by_context();
+foreach ($contextdata as $contextid => $numcoderunnerquestions) {
     if ($skipping && $contextid != $startfromcontextid) {
         continue;
     }
     $skipping = false;
-
     $testcontext = context::instance_by_id($contextid);
     if (has_capability('moodle/question:editall', $context)) {
+        $PAGE->set_context($testcontext);  // Helps grading cache pickup right course id.
+        $bulktester = new qtype_coderunner_bulk_tester($testcontext);
         echo $OUTPUT->heading(get_string('bulktesttitle', 'qtype_coderunner', $testcontext->get_context_name()));
         echo html_writer::tag('p', html_writer::link(
             new moodle_url(
@@ -77,13 +78,13 @@
             get_string('bulktestcontinuefromhere', 'qtype_coderunner')
         ));
 
-        [$passes, $failingtests, $missinganswers] = $bulktester->run_all_tests_for_context($testcontext);
+        [$passes, $failingtests, $missinganswers] = $bulktester->run_all_tests_for_context();
         $numpasses += $passes;
         $allfailingtests = array_merge($allfailingtests, $failingtests);
         $allmissinganswers = array_merge($allmissinganswers, $missinganswers);
     }
 }
 
 // Display the final summary.
-$bulktester->print_overall_result($numpasses, $allfailingtests, $allmissinganswers);
+qtype_coderunner_bulk_tester::print_summary_after_bulktestall($numpasses, $allfailingtests, $allmissinganswers);
 echo $OUTPUT->footer();

classes/bulk_tester.php

@@ -313,7 +313,7 @@ public function run_all_tests_for_context($questionidstoinclude = []) {
         } else {
             $qparams['courseid'] = SITEID;
         }
-        $questiontestsurl = new moodle_url('/question/type/coderunner/questiontestrun.php');
+         $questiontestsurl = new moodle_url('/question/type/coderunner/questiontestrun.php');
         $questiontestsurl->params($qparams);
 
         $this->numpasses = 0;
@@ -404,7 +404,7 @@ public function run_all_tests_for_context($questionidstoinclude = []) {
             }
             echo "</ul>\n";
         }
-        return;
+        return [$this->numpasses, $this->failedtestdetails, $this->missinganswerdetails];
     }
 
 
@@ -497,8 +497,6 @@ public function print_overall_result() {
             }
             echo html_writer::end_tag('ul');
         }
-
-
         if (count($this->failedtestdetails) > 0) {
             echo $OUTPUT->heading(get_string('coderunner_install_testsuite_failures', 'qtype_coderunner'), 5);
             echo html_writer::start_tag('ul');
@@ -532,6 +530,36 @@ public function print_overall_result() {
         echo html_writer::tag('p', $link);
     }
 
+    /**
+     * Print an overall summary of the failed tests.
+     */
+    public static function print_summary_after_bulktestall($numpasses, $allfailingtests, $allmissinganswers) {
+        global $OUTPUT;
+        echo $OUTPUT->heading(get_string('bulktestoverallresults', 'qtype_coderunner'), 5);
+        $spacer = '&nbsp;&nbsp;|&nbsp;&nbsp;';
+        $passstr = $numpasses . ' ' . get_string('passes', 'qtype_coderunner') . $spacer;
+        $failstr = count($allfailingtests) . ' ' . get_string('fails', 'qtype_coderunner') . $spacer;
+        $missingstr = count($allmissinganswers) . ' ' . get_string('missinganswers', 'qtype_coderunner');
+        echo html_writer::tag('p', $passstr . $failstr . $missingstr);
+
+        if (count($allmissinganswers) > 0) {
+            echo $OUTPUT->heading(get_string('coderunner_install_testsuite_noanswer', 'qtype_coderunner'), 5);
+            echo html_writer::start_tag('ul');
+            foreach ($allmissinganswers as $message) {
+                echo html_writer::tag('li', $message);
+            }
+            echo html_writer::end_tag('ul');
+        }
+        if (count($allfailingtests) > 0) {
+            echo $OUTPUT->heading(get_string('coderunner_install_testsuite_failures', 'qtype_coderunner'), 5);
+            echo html_writer::start_tag('ul');
+            foreach ($allfailingtests as $message) {
+                echo html_writer::tag('li', $message);
+            }
+            echo html_writer::end_tag('ul');
+        }
+    }
+
 
     /**
      *  Display the results of scanning all the CodeRunner questions to