From 01898bf39a060cb03ba38c4d6f7baea9559ad2ba Mon Sep 17 00:00:00 2001 From: Samay Sofo Date: Tue, 25 Feb 2025 19:56:53 +0000 Subject: [PATCH] refactored test --- .../mto_service_item_creator_test.go | 4 ++-- .../transportation_office_fetcher_test.go | 12 ++++++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/pkg/services/mto_service_item/mto_service_item_creator_test.go b/pkg/services/mto_service_item/mto_service_item_creator_test.go index 4158bcd3d14..ee468bd232a 100644 --- a/pkg/services/mto_service_item/mto_service_item_creator_test.go +++ b/pkg/services/mto_service_item/mto_service_item_creator_test.go @@ -1288,7 +1288,7 @@ func (suite *MTOServiceItemServiceSuite) TestCreateOriginSITServiceItem() { }, }, nil) builder := query.NewQueryBuilder() - moveRouter := moverouter.NewMoveRouter() + moveRouter := moverouter.NewMoveRouter(transportationoffice.NewTransportationOfficesFetcher()) planner := &mocks.Planner{} planner.On("ZipTransitDistance", mock.AnythingOfType("*appcontext.appContext"), @@ -1334,7 +1334,7 @@ func (suite *MTOServiceItemServiceSuite) TestCreateOriginSITServiceItem() { }, }, nil) builder := query.NewQueryBuilder() - moveRouter := moverouter.NewMoveRouter() + moveRouter := moverouter.NewMoveRouter(transportationoffice.NewTransportationOfficesFetcher()) planner := &mocks.Planner{} planner.On("ZipTransitDistance", mock.AnythingOfType("*appcontext.appContext"), diff --git a/pkg/services/transportation_office/transportation_office_fetcher_test.go b/pkg/services/transportation_office/transportation_office_fetcher_test.go index b5a52b13140..908fd93870a 100644 --- a/pkg/services/transportation_office/transportation_office_fetcher_test.go +++ b/pkg/services/transportation_office/transportation_office_fetcher_test.go @@ -642,12 +642,20 @@ func (suite *TransportationOfficeServiceSuite) Test_FindCounselingOfficeForPrime }) suite.Run("failure - not found duty location returns error", func() { + _, oconusRateArea, _, _ := setupDataForOconusSearchCounselingOffice("99619", "MAPS") + + // setup department affiliation to GBLOC mappings + jppsoRegion, err := models.FetchJppsoRegionByCode(suite.DB(), "MAPS") + suite.NotNil(jppsoRegion) + suite.Nil(err) + gblocAors, err := models.FetchGblocAorsByJppsoCodeRateAreaDept(suite.DB(), jppsoRegion.ID, oconusRateArea.ID, models.DepartmentIndicatorARMY.String()) + suite.NotNil(gblocAors) + suite.Nil(err) appCtx := suite.AppContextWithSessionForTest(&auth.Session{ ServiceMemberID: uuid.Must(uuid.NewV4()), }) unknown_duty_location_id := uuid.Must(uuid.NewV4()) - offices, err := findCounselingOffice(appCtx, unknown_duty_location_id, appCtx.Session().ServiceMemberID) - suite.Nil(offices) + _, err = suite.toFetcher.FindCounselingOfficeForPrimeCounseled(appCtx, unknown_duty_location_id, appCtx.Session().ServiceMemberID) suite.NotNil(err) })