Merge pull request #14634 from transcom/B-21947-MAIN

[PAPI] B-21947 MAIN - Return customer backup contact info in getMoveTaskOrder
transcom · Jan 24, 2025 · a6db028 · a6db028
2 parents 1df926b + abb342f
commit a6db028
Show file tree

Hide file tree

Showing 37 changed files with 766 additions and 33 deletions.
diff --git a/pkg/factory/backup_contact_factory.go b/pkg/factory/backup_contact_factory.go
@@ -35,7 +35,7 @@ func BuildBackupContact(db *pop.Connection, customs []Customization, traits []Tr
 		Permission:      models.BackupContactPermissionEDIT,
 		Name:            "name",
 		Email:           "email@example.com",
-		Phone:           models.StringPointer("555-555-5555"),
+		Phone:           "555-555-5555",
 	}
 
 	// Overwrite values with those from customizations

diff --git a/pkg/factory/backup_contact_factory_test.go b/pkg/factory/backup_contact_factory_test.go
@@ -18,7 +18,7 @@ func (suite *FactorySuite) TestBuildBackupContact() {
 			Permission: models.BackupContactPermissionEDIT,
 			Name:       "name",
 			Email:      "email@example.com",
-			Phone:      models.StringPointer("555-555-5555"),
+			Phone:      "555-555-5555",
 		}
 		defaultServiceMember := models.ServiceMember{
 			FirstName: models.StringPointer("Leo"),
@@ -33,7 +33,7 @@ func (suite *FactorySuite) TestBuildBackupContact() {
 		suite.Equal(defaultContact.Permission, backupContact.Permission)
 		suite.Equal(defaultContact.Name, backupContact.Name)
 		suite.Equal(defaultContact.Email, backupContact.Email)
-		suite.Equal(*defaultContact.Phone, *backupContact.Phone)
+		suite.Equal(defaultContact.Phone, backupContact.Phone)
 
 		// Check that service member was hooked in
 		suite.Equal(*defaultServiceMember.FirstName, *backupContact.ServiceMember.FirstName)
@@ -52,7 +52,7 @@ func (suite *FactorySuite) TestBuildBackupContact() {
 			ID:         uuid.Must(uuid.NewV4()),
 			Name:       "Fake Name",
 			Email:      "email@example.com",
-			Phone:      models.StringPointer("555-444-4444"),
+			Phone:      "555-444-4444",
 			Permission: models.BackupContactPermissionVIEW,
 		}
 
@@ -72,7 +72,7 @@ func (suite *FactorySuite) TestBuildBackupContact() {
 		suite.Equal(customBackupContact.Name, backupContact.Name)
 		suite.Equal(customBackupContact.Email, backupContact.Email)
 		suite.Equal(customBackupContact.Permission, backupContact.Permission)
-		suite.Equal(*customBackupContact.Phone, *backupContact.Phone)
+		suite.Equal(customBackupContact.Phone, backupContact.Phone)
 
 		// Check that the service member was customized
 		suite.Equal(*customServiceMember.FirstName, *backupContact.ServiceMember.FirstName)

diff --git a/pkg/gen/primeapi/embedded_spec.go b/pkg/gen/primeapi/embedded_spec.go
diff --git a/pkg/gen/primemessages/backup_contact.go b/pkg/gen/primemessages/backup_contact.go
diff --git a/pkg/gen/primemessages/customer.go b/pkg/gen/primemessages/customer.go
diff --git a/pkg/gen/primev2api/embedded_spec.go b/pkg/gen/primev2api/embedded_spec.go