Fixed duplicate if statement block and coverage for mobile home shipment

Author: Brooklyn Welsh

pkg/services/move/move_router.go

@@ -219,26 +219,20 @@ func (router moveRouter) sendToServiceCounselor(appCtx appcontext.AppContext, mo
 				return apperror.NewInvalidInputError(move.MTOShipments[i].ID, err, verrs, msg)
 			}
 
-			if verrs, err := appCtx.DB().ValidateAndUpdate(move.MTOShipments[i].BoatShipment); verrs.HasAny() || err != nil {
-				msg := "failure saving boat shipment when routing move submission"
-				appCtx.Logger().Error(msg, zap.Error(err))
-				return apperror.NewInvalidInputError(move.MTOShipments[i].ID, err, verrs, msg)
-			}
-		}
-		// update status for mobile home shipment
-		if move.MTOShipments[i].ShipmentType == models.MTOShipmentTypeMobileHome {
-			move.MTOShipments[i].Status = models.MTOShipmentStatusSubmitted
-
-			if verrs, err := appCtx.DB().ValidateAndUpdate(&move.MTOShipments[i]); verrs.HasAny() || err != nil {
-				msg := "failure saving parent MTO shipment object for mobile home shipment when routing move submission"
-				appCtx.Logger().Error(msg, zap.Error(err))
-				return apperror.NewInvalidInputError(move.MTOShipments[i].ID, err, verrs, msg)
+			if move.MTOShipments[i].BoatShipment != nil {
+				if verrs, err := appCtx.DB().ValidateAndUpdate(move.MTOShipments[i].BoatShipment); verrs.HasAny() || err != nil {
+					msg := "failure saving boat shipment when routing move submission"
+					appCtx.Logger().Error(msg, zap.Error(err))
+					return apperror.NewInvalidInputError(move.MTOShipments[i].ID, err, verrs, msg)
+				}
 			}
 
-			if verrs, err := appCtx.DB().ValidateAndUpdate(move.MTOShipments[i].MobileHome); verrs.HasAny() || err != nil {
-				msg := "failure saving mobile home shipment when routing move submission"
-				appCtx.Logger().Error(msg, zap.Error(err))
-				return apperror.NewInvalidInputError(move.MTOShipments[i].ID, err, verrs, msg)
+			if move.MTOShipments[i].MobileHome != nil {
+				if verrs, err := appCtx.DB().ValidateAndUpdate(move.MTOShipments[i].MobileHome); verrs.HasAny() || err != nil {
+					msg := "failure saving mobile home shipment when routing move submission"
+					appCtx.Logger().Error(msg, zap.Error(err))
+					return apperror.NewInvalidInputError(move.MTOShipments[i].ID, err, verrs, msg)
+				}
 			}
 		}