Skip to content

Commit

Permalink
Merge branch 'main' into dependabot/go_modules/github.com/go-openapi/…
Browse files Browse the repository at this point in the history
…loads-0.21.5
  • Loading branch information
deandreJones authored Jan 15, 2024
2 parents 903adfc + 824c670 commit f870708
Show file tree
Hide file tree
Showing 166 changed files with 5,040 additions and 6,455 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ executors:

commands:
create_dot_go_version:
description: "Creates a .go-version file (if needed) which can be used for cache keys specific to golang"
description: 'Creates a .go-version file (if needed) which can be used for cache keys specific to golang'
steps:
- run:
name: Create a .go-version file
Expand Down Expand Up @@ -1237,7 +1237,7 @@ jobs:
#
# The trailing hyphen in restore_cache seems important
# according to the page linked above
- v6-spectral-lint-
- v8-spectral-lint-
- run:
name: Save Baseline Spectral Lint
command: |
Expand Down Expand Up @@ -1296,7 +1296,7 @@ jobs:
# Use the BuildNum to update the cache key so that the
# coverage cache is always updated
- save_cache:
key: v6-spectral-lint-{{ .BuildNum }}
key: v8-spectral-lint-{{ .BuildNum }}
paths:
- ~/transcom/mymove/spectral
- store_artifacts:
Expand Down
1 change: 1 addition & 0 deletions migrations/app/migrations_manifest.txt
Original file line number Diff line number Diff line change
Expand Up @@ -888,3 +888,4 @@
20231218144414_mto_shipment_diverted_from_shipment_id.up.sql
20231226174935_create_ppm_documents_triggers.up.sql
20240103174317_add_customer_expense.up.sql
20240109200110_add_address_columns_to_ppmshipments4.up.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ALTER TABLE public.ppm_shipments
ADD COLUMN pickup_postal_address_id uuid NULL,
ADD COLUMN secondary_pickup_postal_address_id uuid NULL,
ADD COLUMN destination_postal_address_id uuid NULL,
ADD COLUMN secondary_destination_postal_address_id uuid NULL;
ALTER TABLE public.ppm_shipments
ADD CONSTRAINT ppm_shipments_pickup_postal_address_fkey FOREIGN KEY (pickup_postal_address_id) REFERENCES public.addresses(id),
ADD CONSTRAINT ppm_shipments_secondary_pickup_postal_address_fkey FOREIGN KEY (secondary_pickup_postal_address_id) REFERENCES public.addresses(id),
ADD CONSTRAINT ppm_shipments_destination_postal_address_fkey FOREIGN KEY (destination_postal_address_id) REFERENCES public.addresses(id),
ADD CONSTRAINT ppm_shipments_secondary_destination_postal_address_fkey FOREIGN KEY (secondary_destination_postal_address_id) REFERENCES public.addresses(id);
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@
"recursive-readdir": "^2.2.3",
"semver": "^7.5.2",
"url-parse": "^1.5.1",
"y18n": "^5.0.5"
"y18n": "^5.0.5",
"follow-redirects": "^1.15.4"
},
"name": "client",
"private": true,
Expand Down Expand Up @@ -139,7 +140,7 @@
"@storybook/addon-links": "^7.2.0",
"@storybook/jest": "^0.1.0",
"@storybook/preset-create-react-app": "^7.6.7",
"@storybook/preview-api": "^7.4.2",
"@storybook/preview-api": "^7.6.8",
"@storybook/react": "^7.2.0",
"@storybook/react-webpack5": "^7.2.0",
"@storybook/testing-library": "^0.2.0",
Expand Down
43 changes: 24 additions & 19 deletions pkg/assets/notifications/templates/reweigh_requested_template.html
Original file line number Diff line number Diff line change
@@ -1,27 +1,32 @@
<p><strong>*** DO NOT REPLY directly to this email ***</strong></p>
<p><strong>*** This is an email generated by the U.S. Government system – MilMove. ***</strong></p>

<p><strong>Essential information</strong></p>
<ul>
<li>MilMove let your movers know that they need to reweigh your HHG shipment before they deliver it to your destination</li>
<li>Your movers will tell you where and when they’ll perform the reweigh</li>
<li>You have the right to witness the reweigh, but you do not have to</li>
<li>Your shipment must be reweighed before it reaches your destination.</li>
<li>Your HomeSafe Alliance (HSA) Customer Care Representative will tell you where and when they will perform the reweigh.</li>
<li>You have the right to witness the reweigh, but it is your decision whether to do so.</li>
</ul>

<p><strong>Why was a reweigh requested?</strong></p>
<p>When MilMove notices that you might move more weight than your weight allowance, the system will automatically request a reweigh.</p>
<p>This happens when a shipment’s weight brings you within 10% of your weight allowance.</p>
<p>It’s also possible for a transportation officer to manually request a reweigh for a shipment.</p>
<p>You can always request a reweigh yourself until the shipment has been unloaded.</p>
<p>The advantage for you: The official weight of your shipment will be the lower weight between the original weighing and the reweigh.</p>
<p>Remember, if you move more weight than your allowance, you have to pay for the extra. A reweigh makes sure you end up with the lowest weight total possible.</p>
<p>When a shipment’s weight brings you <strong><u>within 10% (or above) your standard weight allowance</u></strong>, the system will automatically request a reweigh.</p>
<p>It is also possible for a transportation office to manually request a reweigh for a shipment.</p>
<p>The official weight of your shipment will be the lower net weight between the original weighing and the reweigh.</p>
<p>Remember, if you move more weight than your allowance, you are subject to excess cost charges pending a review of all shipment(s) weights.</p>

<p><strong>What do I need to do?</strong></p>
<p>Your movers will let you know <strong>where</strong> and <strong>when</strong> they will reweigh your shipment.</p>
<p>Reweighs typically happen near your destination and close to your delivery date.</p>
<p>You’re entitled to witness the reweigh yourself, or send someone else to do it on your behalf. This is optional. You do not have to attend the reweigh.</p>
<p><strong>What do you need to do?</strong></p>
<p>Nothing, unless you wish to witness the reweigh.</p>
<p>If you wish to witness the reweigh, your HSA Customer Care Representative is required to let you know <strong>when</strong> and <strong>where</strong> they will reweigh your shipment (any cost incurred to witness a reweigh is at your own expense).</p>
<p>Reweighs typically happen near your destination and close to your delivery date; however, this is not always the case. If your shipment goes into storage-in-transit (SIT) and the transportation service provider (TSP) does not reweigh it beforehand, the TSP still has the opportunity to perform a reweigh after you schedule a delivery date and your personal property leaves the warehouse.</p>

<p><strong>Who should I talk to about my reweigh?</strong></p>
<p>Your movers will be arranging the logistics of the reweigh. You should talk to them directly if you have questions or arrange to be present for the reweigh.</p>
<p>If your movers don’t give you a date and time for this reweigh soon, ask them for that info.</p>
<p><strong>Who should you talk to about the reweigh?</strong></p>
<p>Your HSA Customer Care Representative will be arranging the logistics of the reweigh. You should talk to them directly if you have questions or wish to be present for the reweigh.</p>
<p>If your HSA Customer Care Representative does not give you a date and time for this reweigh, ask them for this information.</p>

<p><strong>Make sure your movers have reweighed your shipment before you accept delivery.</strong></p>
<p>The only reason they can reject a reweigh request is if they get the request after the shipment has been unloaded.</p>
<p>If you believe your shipment should be reweighed and has not been, do not accept delivery. Tell your movers that they need to reweigh the shipment before they unload it.</p>
<p><strong>Make sure your shipment has been reweighed before you accept delivery.</strong></p>
<p>The only time a reweigh cannot be performed is when the shipment has already been unloaded.</p>
<p>If you believe your shipment should be reweighed and has not been, do not accept delivery. Tell your HSA Customer Care Representative that they need to reweigh the shipment before they unload it.</p>
<p>Remember, your HomeSafe Alliance (HSA) Customer Care Representative is your first point of contact; however, if you are unsatisfied at any time, contact a government transportation office. You can see a listing of transportation offices on Military One Source here: <a href="https://www.militaryonesource.mil/benefits/militaryinstallations-local-transportation-office/.">https://www.militaryonesource.mil/benefits/militaryinstallations-local-transportation-office/</a>.</p>
<p>Thank you,</p>
<p>Defense Personal Property Program’s MilMove Team</p>
<p>The information contained in this email may contain Privacy Act information and is therefore protected under the Privacy Act of 1974. Failure to protect Privacy Act information could result in a $5,000 fine.</p>
45 changes: 26 additions & 19 deletions pkg/assets/notifications/templates/reweigh_requested_template.txt
Original file line number Diff line number Diff line change
@@ -1,35 +1,42 @@
*** DO NOT REPLY directly to this email ***

*** This is an email generated by the U.S. Government system – MilMove. ***

Essential information
* MilMove let your movers know that they need to reweigh your HHG shipment before they deliver it to your destination
* Your movers will tell you where and when they’ll perform the reweigh
* You have the right to witness the reweigh, but you do not have to
* Your shipment must be reweighed before it reaches your destination.
* Your HomeSafe Alliance (HSA) Customer Care Representative will tell you where and when they will perform the reweigh.
* You have the right to witness the reweigh, but it is your decision whether to do so.

Why was a reweigh requested?
When MilMove notices that you might move more weight than your weight allowance, the system will automatically request a reweigh.
When a shipment’s weight brings you within 10% (or above) your standard weight allowance, the system will automatically request a reweigh.

It is also possible for a transportation office to manually request a reweigh for a shipment.

This happens when a shipment’s weight brings you within 10% of your weight allowance.
The official weight of your shipment will be the lower net weight between the original weighing and the reweigh.

It’s also possible for a transportation officer to manually request a reweigh for a shipment.
Remember, if you move more weight than your allowance, you are subject to excess cost charges pending a review of all shipment(s) weights.

You can always request a reweigh yourself until the shipment has been unloaded.
What do you need to do?
Nothing, unless you wish to witness the reweigh.

The advantage for you: The official weight of your shipment will be the lower weight between the original weighing and the reweigh.
If you wish to witness the reweigh, your HSA Customer Care Representative is required to let you know when and where they will reweigh your shipment (any cost incurred to witness a reweigh is at your own expense).

Remember, if you move more weight than your allowance, you have to pay for the extra. A reweigh makes sure you end up with the lowest weight total possible.
Reweighs typically happen near your destination and close to your delivery date; however, this is not always the case. If your shipment goes into storage-in-transit (SIT) and the transportation service provider (TSP) does not reweigh it beforehand, the TSP still has the opportunity to perform a reweigh after you schedule a delivery date and your personal property leaves the warehouse.

What do I need to do?
Your movers will let you know where and when they will reweigh your shipment.
Who should you talk to about the reweigh?
Your HSA Customer Care Representative will be arranging the logistics of the reweigh. You should talk to them directly if you have questions or wish to be present for the reweigh.

Reweighs typically happen near your destination and close to your delivery date.
If your HSA Customer Care Representative does not give you a date and time for this reweigh, ask them for this information.

You’re entitled to witness the reweigh yourself, or send someone else to do it on your behalf. This is optional. You do not have to attend the reweigh.
Make sure your shipment has been reweighed before you accept delivery.
The only time a reweigh cannot be performed is when the shipment has already been unloaded.

Who should I talk to about my reweigh?
Your movers will be arranging the logistics of the reweigh. You should talk to them directly if you have questions or arrange to be present for the reweigh.
If you believe your shipment should be reweighed and has not been, do not accept delivery. Tell your HSA Customer Care Representative that they need to reweigh the shipment before they unload it.

If your movers don’t give you a date and time for this reweigh soon, ask them for that info.
Remember, your HomeSafe Alliance (HSA) Customer Care Representative is your first point of contact; however, if you are unsatisfied at any time, contact a government transportation office. You can see a listing of transportation offices on Military One Source here: https://www.militaryonesource.mil/benefits/militaryinstallations-local-transportation-office/.

Make sure your movers have reweighed your shipment before you accept delivery.
Thank you,

The only reason they can reject a reweigh request is if they get the request after the shipment has been unloaded.
Defense Personal Property Program’s MilMove Team

If you believe your shipment should be reweighed and has not been, do not accept delivery. Tell your movers that they need to reweigh the shipment before they unload it.
The information contained in this email may contain Privacy Act information and is therefore protected under the Privacy Act of 1974. Failure to protect Privacy Act information could result in a $5,000 fine.
8 changes: 5 additions & 3 deletions pkg/assets/sql_scripts/move_history_fetcher.sql
Original file line number Diff line number Diff line change
Expand Up @@ -516,10 +516,11 @@ WITH move AS (
),
-- document_review_items grabs historical data for weight ticket, pro-gear
-- weight tickets, and moving expense tickets
document_review_items (doc_id, shipment_type, shipment_id) AS (
document_review_items (doc_id, shipment_type, shipment_id, moving_expense_type) AS (
SELECT COALESCE(wt.id, pwt.id, me.id),
ppms.shipment_type,
ppms.shipment_id
ppms.shipment_id,
me.moving_expense_type
FROM audit_history ah
LEFT JOIN weight_tickets wt ON ah.object_id = wt.id
LEFT JOIN progear_weight_tickets pwt ON ah.object_id = pwt.id
Expand All @@ -533,7 +534,8 @@ WITH move AS (
jsonb_strip_nulls(
jsonb_build_object(
'shipment_type', document_review_items.shipment_type,
'shipment_id_abbr', (CASE WHEN document_review_items.shipment_id IS NOT NULL THEN LEFT(document_review_items.shipment_id::TEXT, 5) ELSE NULL END)
'shipment_id_abbr', (CASE WHEN document_review_items.shipment_id IS NOT NULL THEN LEFT(document_review_items.shipment_id::TEXT, 5) ELSE NULL END),
'moving_expense_type', document_review_items.moving_expense_type
)
)
)::TEXT AS context,
Expand Down
25 changes: 5 additions & 20 deletions pkg/gen/ghcapi/configure_mymove.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation order.AcknowledgeExcessWeightRisk has not yet been implemented")
})
}
if api.MtoServiceItemApproveSITAddressUpdateHandler == nil {
api.MtoServiceItemApproveSITAddressUpdateHandler = mto_service_item.ApproveSITAddressUpdateHandlerFunc(func(params mto_service_item.ApproveSITAddressUpdateParams) middleware.Responder {
return middleware.NotImplemented("operation mto_service_item.ApproveSITAddressUpdate has not yet been implemented")
})
}
if api.ShipmentApproveSITExtensionHandler == nil {
api.ShipmentApproveSITExtensionHandler = shipment.ApproveSITExtensionHandlerFunc(func(params shipment.ApproveSITExtensionParams) middleware.Responder {
return middleware.NotImplemented("operation shipment.ApproveSITExtension has not yet been implemented")
Expand Down Expand Up @@ -117,11 +112,6 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation mto_shipment.CreateMTOShipment has not yet been implemented")
})
}
if api.MtoServiceItemCreateSITAddressUpdateHandler == nil {
api.MtoServiceItemCreateSITAddressUpdateHandler = mto_service_item.CreateSITAddressUpdateHandlerFunc(func(params mto_service_item.CreateSITAddressUpdateParams) middleware.Responder {
return middleware.NotImplemented("operation mto_service_item.CreateSITAddressUpdate has not yet been implemented")
})
}
if api.CustomerSupportRemarksDeleteCustomerSupportRemarkHandler == nil {
api.CustomerSupportRemarksDeleteCustomerSupportRemarkHandler = customer_support_remarks.DeleteCustomerSupportRemarkHandlerFunc(func(params customer_support_remarks.DeleteCustomerSupportRemarkParams) middleware.Responder {
return middleware.NotImplemented("operation customer_support_remarks.DeleteCustomerSupportRemark has not yet been implemented")
Expand Down Expand Up @@ -222,6 +212,11 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation order.GetOrder has not yet been implemented")
})
}
if api.PpmGetPPMCloseoutHandler == nil {
api.PpmGetPPMCloseoutHandler = ppm.GetPPMCloseoutHandlerFunc(func(params ppm.GetPPMCloseoutParams) middleware.Responder {
return middleware.NotImplemented("operation ppm.GetPPMCloseout has not yet been implemented")
})
}
if api.PpmGetPPMDocumentsHandler == nil {
api.PpmGetPPMDocumentsHandler = ppm.GetPPMDocumentsHandlerFunc(func(params ppm.GetPPMDocumentsParams) middleware.Responder {
return middleware.NotImplemented("operation ppm.GetPPMDocuments has not yet been implemented")
Expand Down Expand Up @@ -287,11 +282,6 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation queues.ListPrimeMoves has not yet been implemented")
})
}
if api.MtoServiceItemRejectSITAddressUpdateHandler == nil {
api.MtoServiceItemRejectSITAddressUpdateHandler = mto_service_item.RejectSITAddressUpdateHandlerFunc(func(params mto_service_item.RejectSITAddressUpdateParams) middleware.Responder {
return middleware.NotImplemented("operation mto_service_item.RejectSITAddressUpdate has not yet been implemented")
})
}
if api.ShipmentRejectShipmentHandler == nil {
api.ShipmentRejectShipmentHandler = shipment.RejectShipmentHandlerFunc(func(params shipment.RejectShipmentParams) middleware.Responder {
return middleware.NotImplemented("operation shipment.RejectShipment has not yet been implemented")
Expand Down Expand Up @@ -372,11 +362,6 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation move_task_order.UpdateMTOReviewedBillableWeightsAt has not yet been implemented")
})
}
if api.MtoServiceItemUpdateMTOServiceItemHandler == nil {
api.MtoServiceItemUpdateMTOServiceItemHandler = mto_service_item.UpdateMTOServiceItemHandlerFunc(func(params mto_service_item.UpdateMTOServiceItemParams) middleware.Responder {
return middleware.NotImplemented("operation mto_service_item.UpdateMTOServiceItem has not yet been implemented")
})
}
if api.MtoServiceItemUpdateMTOServiceItemStatusHandler == nil {
api.MtoServiceItemUpdateMTOServiceItemStatusHandler = mto_service_item.UpdateMTOServiceItemStatusHandlerFunc(func(params mto_service_item.UpdateMTOServiceItemStatusParams) middleware.Responder {
return middleware.NotImplemented("operation mto_service_item.UpdateMTOServiceItemStatus has not yet been implemented")
Expand Down
Loading

0 comments on commit f870708

Please sign in to comment.