E 04823 tickets b 18472 and b 18457 main #11892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect changes. This moves grade from service member to order
…instead of service member for ghc invoice generator
…nk-And-Duty-Location
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
traskowskycaci
requested review from
deandreJones,
danieljordan-caci,
TevinAdams and
paulstonebraker
danieljordan-caci
approved these changes
Feb 23, 2024
TevinAdams
approved these changes
Feb 23, 2024
cameroncaci
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration PR
Feature E-04823
Summary
These two tickets introduce new business logic and refactoring with how service member duty location, grade, and weight allotments function within MilMove. At a high level, grade and duty location has moved from the service member to the order. Additionally, grades now reflect a "true" value that is calculated by weight allotment and assigned to a
DBWeightAuthorized.DBWeightAuthorizedis directly tied to the maximum billable weight of a move. When a service member grade is updated, it immediately updated the maximum billable weight, whether it be increasing or decreasing the maximum amount.Verification Steps for Reviewers
pkg/models/entitlements.goSetup to Run the Code
How to test
Frontend:
Backend:
pkg/models/entitlements.go)pkg/models/entitlements.go)HasDependentsvalue on the order to true or false, then update the grade again to review how dependents affect the weight allowance.Screenshots